You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/21 12:01:10 UTC
[GitHub] [flink] zentol opened a new pull request #12948: [FLINK-18533][coordination] Tolerate pending deployments being reported
zentol opened a new pull request #12948:
URL: https://github.com/apache/flink/pull/12948
Fixes an issue where a task would be canceled if a task executor reported the execution via heartbeats without the acknowledgement yet being processed by the JobMaster. This can happen because the Acknowledge was lost, or due to message re-ordering on the JobMaster side.
The `ExecutionDeployment(Tracker/Reconciler)` now distinguish between PENDING/DEPLOYED executions.
For reconciliation purposes executions in a PENDING state are ignored.
Executions are moved into a deployed state once the acknowledge by the TaskExecutor has been processed by the JobMaster.
If the task is never acknowledged, then, as before, the task is failed by the JobMaster, and then removed from the tracker (due to terminal state transition, as before).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #12948: [FLINK-18533][coordination] Tolerate pending deployments being reported
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #12948:
URL: https://github.com/apache/flink/pull/12948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12948: [FLINK-18533][coordination] Tolerate pending deployments being reported
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12948:
URL: https://github.com/apache/flink/pull/12948#issuecomment-661814463
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f681caa7e869c4b85f7f966bfcbb0ff9522bcda3 (Tue Jul 21 12:03:44 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12948: [FLINK-18533][coordination] Tolerate pending deployments being reported
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12948:
URL: https://github.com/apache/flink/pull/12948#issuecomment-661826878
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f681caa7e869c4b85f7f966bfcbb0ff9522bcda3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4686",
"triggerID" : "f681caa7e869c4b85f7f966bfcbb0ff9522bcda3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f681caa7e869c4b85f7f966bfcbb0ff9522bcda3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4686)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12948: [FLINK-18533][coordination] Tolerate pending deployments being reported
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12948:
URL: https://github.com/apache/flink/pull/12948#issuecomment-661826878
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f681caa7e869c4b85f7f966bfcbb0ff9522bcda3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4686",
"triggerID" : "f681caa7e869c4b85f7f966bfcbb0ff9522bcda3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f681caa7e869c4b85f7f966bfcbb0ff9522bcda3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4686)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12948: [FLINK-18533][coordination] Tolerate pending deployments being reported
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12948:
URL: https://github.com/apache/flink/pull/12948#issuecomment-661826878
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f681caa7e869c4b85f7f966bfcbb0ff9522bcda3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f681caa7e869c4b85f7f966bfcbb0ff9522bcda3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f681caa7e869c4b85f7f966bfcbb0ff9522bcda3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org