You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2009/05/05 01:45:30 UTC
[jira] Updated: (HADOOP-5236) Unreachable code in
TaskInProgress.inCompleteSubTask
[ https://issues.apache.org/jira/browse/HADOOP-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5236:
----------------------------------
Status: Open (was: Patch Available)
Unfortunately the patch is now stale.
> Unreachable code in TaskInProgress.inCompleteSubTask
> ----------------------------------------------------
>
> Key: HADOOP-5236
> URL: https://issues.apache.org/jira/browse/HADOOP-5236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: patch-5236-1.txt, patch-5236.txt
>
>
> TaskInProgress.incompleteSubTask has the following unreachable-code :
> {noformat}
> if (taskState != TaskStatus.State.FAILED &&
> taskState != TaskStatus.State.KILLED &&
> taskState != TaskStatus.State.FAILED_UNCLEAN &&
> taskState != TaskStatus.State.KILLED_UNCLEAN) {
> LOG.info("Task '" + taskid + "' running on '" + trackerName +
> "' in state: '" + taskState + "' being failed!");
> status.setRunState(TaskStatus.State.FAILED);
> taskState = TaskStatus.State.FAILED;
> }
> {noformat}
> It would never reach this code, because it is never called from other places, where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
> Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.