[GitHub] [trafficserver] maskit commented on a diff in pull request #9336: Fixed some memory leaks with http/3

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on code in PR #9336:
URL: https://github.com/apache/trafficserver/pull/9336#discussion_r1092217030


##########
proxy/http3/Http3Session.cc:
##########
@@ -55,6 +55,7 @@ void
 HQSession::remove_transaction(HQTransaction *trans)
 {
   this->_transaction_list.remove(trans);
+  delete trans;

Review Comment:
   I feel like I want to delete transactions on the caller side, but I'll propose the change later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org