You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by ra...@apache.org on 2017/02/27 06:13:00 UTC
zookeeper git commit: ZOOKEEPER-2696: Eclipse ant ask no longer
determines correct classpath for tests after ZOOKEEPER-2689
Repository: zookeeper
Updated Branches:
refs/heads/branch-3.4 373b82bab -> b26eaf349
ZOOKEEPER-2696: Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689
After pulling branch-3.4 i noticed that I could no longer compile and run the tests within my IDE.
The .classpath file generated by the eclipse ant task was missing necessary dependencies. These missing dependencies all appear to be transitive from dependencies brought in by ZOOKEEPER-2689 (which is why ant is able to run the tests). There were two possible ways to fix this, this patch explicitly lists the new transitive dependencies that are required by our test code. Another solution would be to remove `transitive="false"` from `<ivy:cachepath pathid="junit.path.id" conf="test" transitive="false"/>` in the eclipse target of our `build.xml`. This solution would introduce even more transitive dependencies to the .classpath.
Author: Abraham Fine <ab...@cloudera.com>
Reviewers: Rakesh Radhakrishnan <ra...@apache.org>
Closes #178 from afine/ZOOKEEPER-2696
Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/b26eaf34
Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/b26eaf34
Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/b26eaf34
Branch: refs/heads/branch-3.4
Commit: b26eaf3492a43821f648d8a8f87d8ac3488f1cef
Parents: 373b82b
Author: Abraham Fine <ab...@cloudera.com>
Authored: Mon Feb 27 17:23:36 2017 +0530
Committer: Rakesh Radhakrishnan <ra...@apache.org>
Committed: Mon Feb 27 17:23:36 2017 +0530
----------------------------------------------------------------------
build.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zookeeper/blob/b26eaf34/build.xml
----------------------------------------------------------------------
diff --git a/build.xml b/build.xml
index 9c13474..423eb5e 100644
--- a/build.xml
+++ b/build.xml
@@ -1797,7 +1797,7 @@ xmlns:maven="antlib:org.apache.maven.artifact.ant">
description="Create eclipse project files">
<ivy:resolve useOrigin="true" conf="test"/>
<ivy:cachepath pathid="default.path.id" conf="default" />
- <ivy:cachepath pathid="junit.path.id" conf="test" transitive="false"/>
+ <ivy:cachepath pathid="junit.path.id" conf="test" />
<taskdef name="eclipse"
classname="prantl.ant.eclipse.EclipseTask"
classpathref="java.classpath" />