[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #16819: Handle SpringBootPropertiesConfiguration not lazily registered in ShardingSphereAutoConfiguration

[GitBox <gi...@apache.org>]

linghengqian commented on code in PR #16819:
URL: https://github.com/apache/shardingsphere/pull/16819#discussion_r850895778


##########
shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/java/org/apache/shardingsphere/spring/boot/ShardingSphereAutoConfiguration.java:
##########
@@ -63,6 +64,7 @@ public class ShardingSphereAutoConfiguration implements EnvironmentAware {
     
     private String databaseName;
     
+    @Lazy

Review Comment:
   Of course, in the long run, other classes should not continue to be injected into the classes registered in the Spring container in advance. But this is not easy to handle, and it is likely to require the existence of unit tests for Spring Boot 2.x in the project, and the project is currently Using Spring Boot 1.x for unit testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org