You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/07 08:18:08 UTC

[GitHub] [pulsar] 315157973 commented on a change in pull request #14061: [Broker] Adjust the validation for policy schemaCompatibilityStrategy

315157973 commented on a change in pull request #14061:
URL: https://github.com/apache/pulsar/pull/14061#discussion_r800403287



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -4837,7 +4839,9 @@ private void internalGetReplicatedSubscriptionStatusForNonPartitionedTopic(Async
     }
 
     protected CompletableFuture<Void> internalSetSchemaCompatibilityStrategy(SchemaCompatibilityStrategy strategy) {
-        return validateTopicOperationAsync(topicName, TopicOperation.SET_SCHEMA_COMPATIBILITY_STRATEGY)
+        return validateTopicPolicyOperationAsync(topicName,
+                PolicyName.SCHEMA_COMPATIBILITY_STRATEGY,

Review comment:
       Could there be a compatibility issue here? 
   In addition, please add a unit test




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org