You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/09 08:51:55 UTC
[GitHub] [iotdb] JackieTien97 opened a new pull request, #7550: Make sure FI won't be aborted by timeout checker by mistake
JackieTien97 opened a new pull request, #7550:
URL: https://github.com/apache/iotdb/pull/7550
I found a strange thing in CI failure.
<img width="1920" alt="image" src="https://user-images.githubusercontent.com/16079446/194747288-8cc6442c-5ee7-4358-b962-d7b5e26ccc9d.png">
The root cause is that the FI is aborted by `DriverTaskTimeoutSentinelThread`. I guess it's caused by Thread.sleep() may not sleep that long, so I add a while loop and some debug logs if it happens again after I add this while loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #7550: Make sure FI won't be aborted by timeout checker by mistake
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged PR #7550:
URL: https://github.com/apache/iotdb/pull/7550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7550: Make sure FI won't be aborted by timeout checker by mistake
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7550:
URL: https://github.com/apache/iotdb/pull/7550#discussion_r990762049
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/fragment/FragmentInstanceExecution.java:
##########
@@ -21,17 +21,22 @@
import org.apache.iotdb.db.mpp.common.FragmentInstanceId;
import org.apache.iotdb.db.mpp.execution.driver.IDriver;
import org.apache.iotdb.db.mpp.execution.exchange.ISinkHandle;
+import org.apache.iotdb.db.mpp.execution.schedule.DriverTaskTimeoutSentinelThread;
import org.apache.iotdb.db.mpp.execution.schedule.IDriverScheduler;
import org.apache.iotdb.db.utils.SetThreadName;
import com.google.common.collect.ImmutableList;
import io.airlift.stats.CounterStat;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import static java.util.Objects.requireNonNull;
import static org.apache.iotdb.db.mpp.execution.fragment.FragmentInstanceState.FAILED;
public class FragmentInstanceExecution {
+ private static final Logger LOGGER =
+ LoggerFactory.getLogger(DriverTaskTimeoutSentinelThread.class);
Review Comment:
```suggestion
private static final Logger LOGGER =
LoggerFactory.getLogger(FragmentInstanceExecution.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org