You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/07/13 15:43:45 UTC
Re: Review Request 60203: Introduce HTB class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60203/#review180434
-----------------------------------------------------------
Fix it, then Ship it!
LGTM!
src/linux/routing/queueing/htb.cpp
Line 136 (original), 127 (patched)
<https://reviews.apache.org/r/60203/#comment255624>
This seems to be unused.
- Ilya Pronin
On July 1, 2017, 12:01 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60203/
> -----------------------------------------------------------
>
> (Updated July 1, 2017, 12:01 a.m.)
>
>
> Review request for mesos, Ilya Pronin, Jie Yu, Santhosh Kumar Shanmugham, and Cong Wang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Based heavily on Cong Wang's original review 45605.
>
> Introduce support for HTB class and expose configuration.
>
>
> Diffs
> -----
>
> src/linux/routing/queueing/class.hpp PRE-CREATION
> src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776
> src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f
> src/linux/routing/queueing/internal.hpp 9fe522ee017c86af8c7b2e518cd0957af08750e4
>
>
> Diff: https://reviews.apache.org/r/60203/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>