[GitHub] [iceberg] kbendick commented on a change in pull request #3982: Doc: update release instructions

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3982:
URL: https://github.com/apache/iceberg/pull/3982#discussion_r792129399



##########
File path: dev/stage-binaries.sh
##########
@@ -18,5 +18,5 @@
 # under the License.
 #
 
-./gradlew -Prelease publishApachePublicationToMavenRepository
+./gradlew -Prelease -DflinkVersions=1.12,1.13,1.14 -DsparkVersions=2.4,3.0,3.1,3.2 -DhiveVersions=2,3 publishApachePublicationToMavenRepository

Review comment:
       Nit / followup: Do we want to make these strings either come from `settings.gradle` or even add them as their own variables in this file for easier update later?
   
   For now this looks totally fine 👍 

##########
File path: site/docs/how-to-release.md
##########
@@ -22,6 +22,17 @@ To create a release candidate, you will need:
 * Apache LDAP credentals for Nexus and SVN
 * A [GPG key for signing](https://www.apache.org/dev/release-signing#generate), published in [KEYS](https://dist.apache.org/repos/dist/dev/iceberg/KEYS)
 
+If you have not published your GPG key yet, you must publish it before sending the vote email by doing:

Review comment:
       Nit: Should we add a note that this is only required for PMC members (binding votes)? Some users might read through this and think they need to do it.
   
   Up to you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org