You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/16 08:30:20 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

tristaZero opened a new issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression
URL: https://github.com/apache/incubator-shardingsphere/issues/4776
 
 
   This issue is to count the `start-index` and `stop-index` to assert `ParameterMarkerExpression `
   
   ### How to find the targets to be fixed?
   1. Open class `ExpressionAssert` and clear the comment of `SQLSegmentAssert.assertIs(assertContext, actual, expected)` in `assertParameterMarkerExpression`.
   2. run `SQLParserParameterizedTest`
   3. All the SQL cases which have the error assertion results are our targets to be fixed.
   
   ### How to fix the above assertion results?
   1. Look at the exception log and find the corresponding `SQL Case ID` and `SQL`.
   2. Find out the `parsing result` of this `SQL Case ID` in `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml`
   3. Calculate the correct `start-index` and `stop-index` of `parameter-marker-expression` segment (i.e., `?`) of this `SQL`.
   4. Add the calculated `start-index` and `stop-index` labels of `parameter-marker-expression` segment to `parsing result` of this `SQL Case ID`, like
   ```
               <parameter-marker-expression value="2" start-index="10" stop-index="11" />
   ```
   5. Run `SQLParserParameterizedTest` again to check whether this `SQL Case ID` does not stay in the list of `SQL` with  `bad assertion result`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression
URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-600959663
 
 
   @geomonlin Hi Any progress made?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression
URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-599409812
 
 
   This issue is part of the `parsing assertion improvement` series which includes,
   #4690

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

Posted by GitBox <gi...@apache.org>.
geomonlin commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression
URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-600960430
 
 
   > @geomonlin Hi Any progress made?
   
   This is basically over. Will submit later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero closed issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression
URL: https://github.com/apache/incubator-shardingsphere/issues/4776
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

Posted by GitBox <gi...@apache.org>.
geomonlin commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression
URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-599413557
 
 
   I‘ll do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] geomonlin edited a comment on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

Posted by GitBox <gi...@apache.org>.
geomonlin edited a comment on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression
URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-600960430
 
 
   > @geomonlin Hi Any progress made?
   
   Hi. This is basically over. Will submit later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services