You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/07 17:01:36 UTC
[GitHub] [flink] zentol opened a new pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
zentol opened a new pull request #12847:
URL: https://github.com/apache/flink/pull/12847
Adds a script for creating the release snapshot branches (e.g., release-1.11).
Covers the git branch creation, updates to docs/config.yml, flink-python/pyflink/version.py and the japicmp configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-663426399
Okay, you are right. I assumed this script was also setting the version in the pom file. However, it doesn't (I should check the code I'm reviewing closer).
Sorry for the confusion. This is good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-663068324
I'm not sure I understand what you are saying.
The script is fine, just the example that you provided confused me, because it created a "release-1.12" branch, where the version was set to "1.12.0" instead of "1.12-SNAPSHOT".
I think you can merge this as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-662271870
I guess you would use this script rather with `RELEASE_VERSION=1.12-SNAPSHOT` instead of `RELEASE_VERSION=1.12.0`? Or am I misunderstanding something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-662916913
> I guess you would use this script rather with RELEASE_VERSION=1.12-SNAPSHOT instead of RELEASE_VERSION=1.12.0?
That's a good point; I'll adjust it to use ${SHORT_RELEASE_VERSION}-SNAPSHOT where appropriate. I'd like this one to work without having to specify additional variables, if the variables from the release guide have been declared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-655020331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311",
"triggerID" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"triggerType" : "PUSH"
}, {
"hash" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4317",
"triggerID" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3301d2b863ff29573adcd6ea3e375a6a841650a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311)
* 2dfe4eaef0d7e13974621c35ea09e5db42735ba3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4317)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-655020331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311",
"triggerID" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"triggerType" : "PUSH"
}, {
"hash" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4317",
"triggerID" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3301d2b863ff29573adcd6ea3e375a6a841650a9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311)
* 2dfe4eaef0d7e13974621c35ea09e5db42735ba3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4317)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-663402463
> The script is fine, just the example that you provided confused me, because it created a "release-1.12" branch, where the version was set to "1.12.0" instead of "1.12-SNAPSHOT".
The properties shown in the example will be set as part of the usual release process (see the `Create a release branch` section in the [guide](https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release).
As such, the example shows what will happen during the normal release process.
You would *not* use it like this: `RELEASE_VERSION=1.12-SNAPSHOT`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #12847:
URL: https://github.com/apache/flink/pull/12847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-655020331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3301d2b863ff29573adcd6ea3e375a6a841650a9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-655020331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311",
"triggerID" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"triggerType" : "PUSH"
}, {
"hash" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4317",
"triggerID" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2dfe4eaef0d7e13974621c35ea09e5db42735ba3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4317)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-662919235
Actually, none of the fields are supposed to contain `-SNAPSHOT`, as seen in the release-1.10 branch / release guide. So you use the script as is without specifying anything special, apart from what is written in the release guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-655020331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311",
"triggerID" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3301d2b863ff29573adcd6ea3e375a6a841650a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-655020331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311",
"triggerID" : "3301d2b863ff29573adcd6ea3e375a6a841650a9",
"triggerType" : "PUSH"
}, {
"hash" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2dfe4eaef0d7e13974621c35ea09e5db42735ba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3301d2b863ff29573adcd6ea3e375a6a841650a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4311)
* 2dfe4eaef0d7e13974621c35ea09e5db42735ba3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12847: [FLINK-18521][release] Add script for creating snapshot branch
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12847:
URL: https://github.com/apache/flink/pull/12847#issuecomment-654998842
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3301d2b863ff29573adcd6ea3e375a6a841650a9 (Tue Jul 07 17:03:45 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org