You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "frankgh (via GitHub)" <gi...@apache.org> on 2023/07/28 16:30:07 UTC
[GitHub] [cassandra] frankgh opened a new pull request, #2535: CASSANDRA-18697 Skip ColumnFamilyStore#topPartitions initialization w…
frankgh opened a new pull request, #2535:
URL: https://github.com/apache/cassandra/pull/2535
…hen client or tool mode
This commit skips the initialization of `topPartitions` in `org.apache.cassandra.db.ColumnFamilyStore` when running in client or tool mode. The `TopPartitionTracker` class will attempt to query the system keyspace, which when running in client or tool mode will not be part of the KeyspaceMetadata. This causes a warning to be printed out with a stacktrace that can be misleading. The warning is similar to this:
```
WARN org.apache.cassandra.db.SystemKeyspace: Could not load stored top SIZES partitions for ...
org.apache.cassandra.db.KeyspaceNotDefinedException: keyspace system does not exist
at org.apache.cassandra.schema.Schema.validateTable(Schema.java:xxx) ~[?:?]
at org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:xxx) ~[?:?]
at org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:xxx) ~[?:?]
at org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:xxx) ~[?:?]
at org.apache.cassandra.cql3.QueryProcessor.parseAndPrepare(QueryProcessor.java:xxx) ~[?:?]
...
```
In this commit, we check whether we run in client or tool mode, and skip initialization of `topPartitions` in those cases.
Cherry-pick from trunk
[CASSANDRA-18697](https://issues.apache.org/jira/browse/CASSANDRA-18697)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] frankgh closed pull request #2535: CASSANDRA-18697 Skip ColumnFamilyStore#topPartitions initialization w…
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh closed pull request #2535: CASSANDRA-18697 Skip ColumnFamilyStore#topPartitions initialization w…
URL: https://github.com/apache/cassandra/pull/2535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] frankgh commented on pull request #2535: CASSANDRA-18697 Skip ColumnFamilyStore#topPartitions initialization w…
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #2535:
URL: https://github.com/apache/cassandra/pull/2535#issuecomment-1661159447
Closed via https://github.com/apache/cassandra/commit/9c796dfb272daa3ce57a2dc5cbeadd9273e1ac72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org