You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/08/07 10:26:53 UTC
[GitHub] spark pull request #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid ...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/22023
[SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakiness
## What changes were proposed in this pull request?
The tests for shuffle can be flaky (eg. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94355/testReport/). This happens because we have not set the seed for `Random`.
## How was this patch tested?
running 10000 times the UT (validated that with a different seed eg. 12345 the test fails).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/spark SPARK-23928_followup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22023.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22023
----
commit b1713d8918c205e325e40ca4eb28eb08909a91f3
Author: Marco Gaido <ma...@...>
Date: 2018-08-07T10:24:09Z
[SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakiness
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22023
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22023
**[Test build #94366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94366/testReport)** for PR 22023 at commit [`b1713d8`](https://github.com/apache/spark/commit/b1713d8918c205e325e40ca4eb28eb08909a91f3).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22023
cc @HyukjinKwon @ueshin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22023
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22023
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94366/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22023
**[Test build #94366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94366/testReport)** for PR 22023 at commit [`b1713d8`](https://github.com/apache/spark/commit/b1713d8918c205e325e40ca4eb28eb08909a91f3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22023
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22023
LGTM.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22023
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1907/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22023: [SPARK-23928][TESTS][FOLLOWUP] Set seed to avoid flakine...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22023
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org