You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/18 08:52:15 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4483: [Improvement-4480][API] change method checkAdmin to isNotAdmin
codecov-io commented on pull request #4483:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4483#issuecomment-762091935
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483?src=pr&el=h1) Report
> Merging [#4483](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483?src=pr&el=desc) (40b0dfb) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/91dfe0913f86748130d26edb653dee62d582e5ca?el=desc) (91dfe09) will **decrease** coverage by `0.00%`.
> The diff coverage is `51.72%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4483 +/- ##
============================================
- Coverage 43.58% 43.57% -0.01%
+ Complexity 3201 3200 -1
============================================
Files 471 471
Lines 21765 21765
Branches 2640 2640
============================================
- Hits 9486 9484 -2
- Misses 11376 11378 +2
Partials 903 903
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/dolphinscheduler/api/service/BaseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQmFzZVNlcnZpY2UuamF2YQ==) | `87.87% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...che/dolphinscheduler/api/service/QueueService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUXVldWVTZXJ2aWNlLmphdmE=) | `75.51% <0.00%> (ø)` | `21.00 <0.00> (ø)` | |
| [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `79.03% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...nscheduler/api/service/impl/TenantServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9UZW5hbnRTZXJ2aWNlSW1wbC5qYXZh) | `67.82% <0.00%> (ø)` | `18.00 <0.00> (ø)` | |
| [...scheduler/api/service/impl/ProjectServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9qZWN0U2VydmljZUltcGwuamF2YQ==) | `87.86% <66.66%> (ø)` | `42.00 <0.00> (ø)` | |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `48.56% <72.72%> (ø)` | `66.00 <0.00> (ø)` | |
| [...olphinscheduler/api/service/AlertGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQWxlcnRHcm91cFNlcnZpY2UuamF2YQ==) | `88.37% <83.33%> (ø)` | `16.00 <0.00> (ø)` | |
| [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `60.97% <0.00%> (-4.88%)` | `7.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483?src=pr&el=footer). Last update [91dfe09...40b0dfb](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org