[GitHub] [helix] kaisun2000 commented on a change in pull request #1201: Identify and shutdown leaked timer threads

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1201:
URL: https://github.com/apache/helix/pull/1201#discussion_r465405655



##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1272,7 +1280,7 @@ protected void checkLiveInstancesObservation(List<LiveInstance> liveInstances,
 
   public void shutdown() throws InterruptedException {
     stopPeriodRebalance();
-
+    stopOnDemandTimer();

Review comment:
       I noticed it too. periodicalRebalanceTimer would be canceled in Finalize and created in init time. But this time before did not do this. Maybe it is for a reason. (Not that familiar with P2P) I am afraid changing its life cycle may cause some unexpected behavior. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org