You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/21 22:38:53 UTC
[GitHub] [incubator-tvm] tkonolige opened a new pull request #6522: Rename tvm.hybrid.script to tvm.script.
tkonolige opened a new pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522
Given the result of the thread https://discuss.tvm.apache.org/t/rfc-rename-hybrid-script/7915/3, new hybrid script (tvm.hybrid.script) is renamed to tvm script.
I think I got all places where tvm.hybrid.script is used, but please verify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-696420692
Thanks @tkonolige . I feel API-wise the module name tvmscript is quite duplicated and long to type.
One quick idea is to introduce the namespace `script`, and do things like
```python
@tvm.script.module
class Module:
def fn1():
pass
mod0 = Module()
mod0.asscript()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-696420692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492395383
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
I agree there might be some confusion that can can discuss further. Since API choice itself is quite important -- we need both conciseness and clarity.
If we want to introduce relay script in the future. Likely we will want to unify with the current tvm script and call them tvm script directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492393034
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Are you sure? That document references `tvm.hybrid.script` and `python/tvm/hybrid/parser.py`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492397005
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
What are the current locations of `python/tvm/hybrid/parser.py` and `python/tvm/hybrid/var_decl.py`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-696420692
Thanks @tkonolige . I feel API-wise the module name tvmscript is quite duplicated and long to type.
One quick idea is to introduce the namespace `script`, and do things like
```python
@tvm.script.module
class Module:
def fn1():
pass
mod0 = Module()
mod0.asscript()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-696420692
Thanks @tkonolige . I feel API-wise the module name tvmscript is quite duplicated and long to type. Because we are already inside the tvm namespace.
One quick idea is to introduce the namespace `script`, and do things like
```python
@tvm.script.module # or @tvm.script.m
class Module:
def fn1():
pass
mod0 = Module()
mod0.asscript()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-696420692
Thanks @tkonolige . I feel API-wise the module name tvmscript is quite duplicated and long to type.
One quick idea is to introduce the namespace `script`, and do things like
```python
@tvm.script.module # or @tvm.script.m
class Module:
def fn1():
pass
mod0 = Module()
mod0.asscript()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-696420692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492393034
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Are you sure? That document references `tvm.hybrid.script` and `python/tvm/hybrid/parser.py`.
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
I think being explicit here is helpful. I'd like to avoid the confusing the different scripts available in TVM. We have hybrid script (old) and tvm script. We might have relay script in the future. If I just say script which am I referring to? Also, the agreement in the Discuss thread seems to be tvm script.
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
What are the current locations of `python/tvm/hybrid/parser.py` and `python/tvm/hybrid/var_decl.py`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-699556736
Thanks @tkonolige @ZihengJiang CC @spectrometerHBH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-696420692
Thanks @tkonolige . I feel API-wise the module name tvmscript is quite duplicated and long to type.
One quick idea is to introduce the namespace `script`, and do things like
```python
@tvm.script.module
class Module:
def fn1():
pass
mod0 = Module()
mod0.asscript()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492393801
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
I think being explicit here is helpful. I'd like to avoid the confusing the different scripts available in TVM. We have hybrid script (old) and tvm script. We might have relay script in the future. If I just say script which am I referring to? Also, the agreement in the Discuss thread seems to be tvm script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492408646
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
I think it refers to https://github.com/apache/incubator-tvm/tree/master/python/tvm/te/hybrid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492386989
##########
File path: python/tvm/tvmscript/__init__.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script APIs of TVM Python Package, aimed to support TIR"""
+"""TVM Script APIs of TVM Python Package, aimed to support TIR"""
-from .utils import create_module, ashybrid, script
+from .utils import create_module, astvmscript, script
Review comment:
astvmscript is a bit too long, how about asscript
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
The name tvmscript was a bit duplicated since we are already in the tvm namespace. How about just tvm/script
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as it was for te.hybrid
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as the dev guide was for te.hybrid not the tvmscript
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Yes, because the te.hybrid used to live in that namespace
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
I agree there might be some confusion that can can discuss further. Since API choice itself is quite important -- we need both conciseness and clarity.
If we want to introduce relay script in the future. Likely we will want to unify with the current tvm script and call them tvm script directly.
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
I think it refers to https://github.com/apache/incubator-tvm/tree/master/python/tvm/te/hybrid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492386353
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as the dev guide was for te.hybrid not the tvmscript
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-699122110
Thanks @tkonolige please fix the lint error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492394227
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Yes, because the te.hybrid used to live in that namespace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492386989
##########
File path: python/tvm/tvmscript/__init__.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script APIs of TVM Python Package, aimed to support TIR"""
+"""TVM Script APIs of TVM Python Package, aimed to support TIR"""
-from .utils import create_module, ashybrid, script
+from .utils import create_module, astvmscript, script
Review comment:
astvmscript is a bit too long, how about asscript
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
The name tvmscript was a bit duplicated since we are already in the tvm namespace. How about just tvm/script
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as it was for te.hybrid
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as the dev guide was for te.hybrid not the tvmscript
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Yes, because the te.hybrid used to live in that namespace
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
I agree there might be some confusion that can can discuss further. Since API choice itself is quite important -- we need both conciseness and clarity.
If we want to introduce relay script in the future. Likely we will want to unify with the current tvm script and call them tvm script directly.
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
I think it refers to https://github.com/apache/incubator-tvm/tree/master/python/tvm/te/hybrid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492393034
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Are you sure? That document references `tvm.hybrid.script` and `python/tvm/hybrid/parser.py`.
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
I think being explicit here is helpful. I'd like to avoid the confusing the different scripts available in TVM. We have hybrid script (old) and tvm script. We might have relay script in the future. If I just say script which am I referring to? Also, the agreement in the Discuss thread seems to be tvm script.
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
What are the current locations of `python/tvm/hybrid/parser.py` and `python/tvm/hybrid/var_decl.py`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#issuecomment-699068913
@tqchen @ZihengJiang I've updated this to match the discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6522: Rename tvm.hybrid.script to tvm.script.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492386989
##########
File path: python/tvm/tvmscript/__init__.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script APIs of TVM Python Package, aimed to support TIR"""
+"""TVM Script APIs of TVM Python Package, aimed to support TIR"""
-from .utils import create_module, ashybrid, script
+from .utils import create_module, astvmscript, script
Review comment:
astvmscript is a bit too long, how about asscript
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
The name tvmscript was a bit duplicated since we are already in the tvm namespace. How about just tvm/script
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as it was for te.hybrid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org