You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/04 23:49:54 UTC
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request
#15715: Improve diagnose.py to display environment variables
marcoabreu commented on a change in pull request #15715: Improve diagnose.py to display environment variables
URL: https://github.com/apache/incubator-mxnet/pull/15715#discussion_r310409500
##########
File path: tools/diagnose.py
##########
@@ -171,6 +161,31 @@ def check_network(args):
for name, url in URLS.items():
test_connection(name, url, args.timeout)
+
+def check_environment():
Review comment:
I'd prefer whitelisting over blacklisting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services