[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23358: [FLINK-33032][table-planner][JUnit5 Migration] Module: flink-table-planner (ExpressionTestBase)

["Jiabao-Sun (via GitHub)" <gi...@apache.org>]

Jiabao-Sun commented on code in PR #23358:
URL: https://github.com/apache/flink/pull/23358#discussion_r1319908902


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/DecimalTypeTest.scala:
##########
@@ -385,11 +385,11 @@ class DecimalTypeTest extends ExpressionTestBase {
 
     testAllApis((-'f51).round(1), "round(-f51,1)", "-100.0")
 
-    testAllApis(('f51).round(-1), "round(f51,-1)", "100")

Review Comment:
   The parentheses in the expression here may be redundant, as they do not change the calculation priority and are equivalent to the expression below. By the way, I removed the brackets in the expression. Do we need this change?
   `'f51.round(-1) is same as '(f51).round(-1)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org