You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ShiKaiWi (via GitHub)" <gi...@apache.org> on 2023/03/27 10:03:51 UTC

[GitHub] [arrow-rs] ShiKaiWi opened a new pull request, #3957: feat: support async writer (#1269)

ShiKaiWi opened a new pull request, #3957:
URL: https://github.com/apache/arrow-rs/pull/3957

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1269.
   
   # Rationale for this change
    Currently, async api for arrow writer has not been supported yet. And if the underlying storage's api is async, it is difficult to use the arrow writer api, and a workaround way is to collect all the bytes in memory and then feed them to the underlying storage by the async api, which may lead to high memory consumption if the final parquet file is large.
   
   So we need an async api for the arrow writer, allowing that the caller can integrate an async underlying storage easily, e.g object store.
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   - Implement the async arrow writer based on the sync arrow writer.
   - The inner buffer of the async arrow writer can be configured with an option called `buffer_flush_threshold` to allow the caller can control the memory usage.
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   `AsyncArrowWriter`.
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ShiKaiWi commented on pull request #3957: feat: support async writer (#1269)

Posted by "ShiKaiWi (via GitHub)" <gi...@apache.org>.
ShiKaiWi commented on PR #3957:
URL: https://github.com/apache/arrow-rs/pull/3957#issuecomment-1484864620

   @tustvold PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ShiKaiWi commented on pull request #3957: feat: support async writer (#1269)

Posted by "ShiKaiWi (via GitHub)" <gi...@apache.org>.
ShiKaiWi commented on PR #3957:
URL: https://github.com/apache/arrow-rs/pull/3957#issuecomment-1485012195

   The ci is broken, I will fix them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #3957: feat: support async writer (#1269)

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3957:
URL: https://github.com/apache/arrow-rs/pull/3957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org