You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 13:12:43 UTC

[GitHub] [spark] LuciferYang edited a comment on pull request #30353: [SPARK-33431][CORE][SQL] Use Option.contains instead of instanceOfOption == Some(x)

LuciferYang edited a comment on pull request #30353:
URL: https://github.com/apache/spark/pull/30353#issuecomment-726055464


   @maropu 
   
   > Seems the before/after examples in the description are the same?
   
   The description has been corrected
   
   > Anyway, the changes sound reasonable. The other sub-modules (e.g., mllib) do not have the pattern (option == Some(x))?
   
   Other modules also have, I can further append new commits to this pr if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org