You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2006/08/07 17:11:08 UTC
Re: [build] Copying deploy directory for federated build
On 7 August 2006 at 18:49, Salikh Zakirov <Sa...@Intel.com> wrote:
> Geir,
>
> you have introduced copying of drlvm deploy directory to get the 'canonical'
> build location
> so that federated build could pick drlvm at predefined place.
>
> I think this is an overkill, making the build process longer with no obvious
> benefits.
If done properly, it should have a benefit. If all the copying is done
so as to fail if it attempts to overwrite anything, then we can see when
different components of the federated build are overwriting files from
other components. Otherwise, to catch errors like this, you have to
implement this check at every step in component ant files. (That isn't
to say we would prohibit components from overwriting, just that we
should make such copies explicit to record that we are doing it
intentionally.)
Regards,
Mark.
> It also has a downside: contents of 'canonical' deploy directory may be absol
> utely non-predictable
> if you run builds on several machines in shared directory.
> The ability to run build on several different machines (of different architec
> tures)
> in a single network-shared workspace was one of the main reasons to introduce
> longish build directory names like 'win_ia32_msvc_debug'.
>
> And your original issue of making federated builds can be served better by th
> e
> following change.
>
> I suggest to remove copying to 'canonical' deploy dir.
> What do you think?
>
> --- enhanced/trunk/build.xml (revision 424297)
> +++ enhanced/trunk/build.xml (working copy)
> @@ -225,14 +225,17 @@
> <target name="build_vm_unix" if="is.unix">
> <exec executable="sh" dir="working_vm/build" >
> <arg line="build.sh update -Dexternal.dep.CLASSLIB.loc=../../../
> working_classlib"/>
> + <arg line="-Dbuild.deploy.dir=../deploy/jre"/>
> <env key="BUILD_CFG" value="release"/>
> </exec>
> <exec executable="sh" dir="working_vm/build" >
> <arg line="build.sh clean -Dexternal.dep.CLASSLIB.loc=../../../w
> orking_classlib"/>
> + <arg line="-Dbuild.deploy.dir=../deploy/jre"/>
> <env key="BUILD_CFG" value="release"/>
> </exec>
> <exec executable="sh" dir="working_vm/build" >
> <arg line="build.sh -Dexternal.dep.CLASSLIB.loc=../../../working
> _classlib"/>
> + <arg line="-Dbuild.deploy.dir=../deploy/jre"/>
> <env key="BUILD_CFG" value="release"/>
> </exec>
> </target>
> @@ -241,16 +244,19 @@
>
> <exec executable="cmd" dir="working_vm/build" >
> <arg line="/c build.bat update -Dexternal.dep.CLASSLIB.loc=../..
> /../working_classlib"/>
> + <arg line="-Dbuild.deploy.dir=../deploy/jre"/>
> <env key="BUILD_CFG" value="release"/>
> <env key="CXX" value="msvc"/>
> </exec>
> <exec executable="cmd" dir="working_vm/build" >
> <arg line="/c build.bat clean -Dexternal.dep.CLASSLIB.loc=../../
> ../working_classlib"/>
> + <arg line="-Dbuild.deploy.dir=../deploy/jre"/>
> <env key="BUILD_CFG" value="release"/>
> <env key="CXX" value="msvc"/>
> </exec>
> <exec executable="cmd" dir="working_vm/build" >
> <arg line="/c build.bat -Dexternal.dep.CLASSLIB.loc=../../../wor
> king_classlib"/>
> + <arg line="-Dbuild.deploy.dir=../deploy/jre"/>
> <env key="BUILD_CFG" value="release"/>
> <env key="CXX" value="msvc"/>
> </exec>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] Copying deploy directory for federated build
Posted by Salikh Zakirov <Sa...@Intel.com>.
Mark Hindess wrote:
> If all the copying is done
> so as to fail if it attempts to overwrite anything, then we can see when
> different components of the federated build are overwriting files from
> other components.
I agree with this statement, however,
my original patch tried to eliminate copying from one deploy directory
to another in *drlvm build*. And the federated build does yet another
copying.
The check for overwriting should go into federated build copying.
Geir Magnusson wrote:
> I think that's fine. Please stuff into a JIRA.
Uploaded patch to HARMONY-1085
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org