[GitHub] [arrow] wjones127 commented on pull request #13108: ARROW-15415: [C++] Fixes for MSVC + vcpkg Debug build

[GitBox <gi...@apache.org>]

wjones127 commented on PR #13108:
URL: https://github.com/apache/arrow/pull/13108#issuecomment-1121587787

   I have been working with these changes in my local, but there is one final error I haven't been able to figure out how to fix.
   
   https://github.com/apache/arrow/blob/d00caa947ea53774e0e6745c857bf622457081ad/cpp/src/arrow/util/tracing.h#L64
   
   ```
   [build] FAILED: src/arrow/CMakeFiles/arrow_shared.dir/compute/exec/tpch_node.cc.obj 
   [build] C:\PROGRA~1\MICROS~4\2022\COMMUN~1\VC\Tools\MSVC\1430~1.307\bin\Hostx64\x64\cl.exe  /nologo /TP -DARROW_EXPORTING -DARROW_EXTRA_ERROR_CONTEXT -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_MIMALLOC -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB -DPROTOBUF_USE_DLLS -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -Darrow_shared_EXPORTS -IC:\Users\voltron\arrow\cpp\build\user-cpp-debug-mscv\src -IC:\Users\voltron\arrow\cpp\src -IC:\Users\voltron\arrow\cpp\src\generated -IC:\Users\voltron\arrow\cpp\thirdparty\flatbuffers\include -IC:\Users\voltron\arrow\cpp\vcpkg_installed\x64-windows\include -IC:\Users\voltron\arrow\cpp\build\user-cpp-debug-mscv\mimalloc_ep\src\mimalloc_ep\include\mimalloc-1.
 7 -IC:\Users\voltron\arrow\cpp\vcpkg_installed\x64-windows\share\rapidjson\..\..\include -IC:\Users\voltron\arrow\cpp\build\user-cpp-debug-mscv\xsimd_ep\src\xsimd_ep-install\include -IC:\Users\voltron\arrow\cpp\thirdparty\hadoop\include /DWIN32 /D_WINDOWS  /GR /EHsc /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING  /W3 /EHsc /wd5105 /bigobj /utf-8 /W3 /wd4365 /wd4267 /wd4838 /WX /wd4800 /wd4996 /wd4065   /MDd /Zi /Ob0 /Od /RTC1 /showIncludes /Fosrc\arrow\CMakeFiles\arrow_shared.dir\compute\exec\tpch_node.cc.obj /Fdsrc\arrow\CMakeFiles\arrow_shared.dir\ /FS -c C:\Users\voltron\arrow\cpp\src\arrow\compute\exec\tpch_node.cc
   [build] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\include\memory(3086): error C2027: use of undefined type 'arrow::internal::tracing::SpanImpl'
   [build] C:\Users\voltron\arrow\cpp\src\arrow/util/tracing.h(30): note: see declaration of 'arrow::internal::tracing::SpanImpl'
   [build] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\include\memory(3085): note: while compiling class template member function 'void std::default_delete<arrow::util::tracing::Span::Impl>::operator ()(_Ty *) noexcept const'
   [build]         with
   [build]         [
   [build]             _Ty=arrow::util::tracing::Span::Impl
   [build]         ]
   [build] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\include\memory(3195): note: see reference to function template instantiation 'void std::default_delete<arrow::util::tracing::Span::Impl>::operator ()(_Ty *) noexcept const' being compiled
   [build]         with
   [build]         [
   [build]             _Ty=arrow::util::tracing::Span::Impl
   [build]         ]
   [build] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\include\memory(3122): note: see reference to class template instantiation 'std::default_delete<arrow::util::tracing::Span::Impl>' being compiled
   [build] C:\Users\voltron\arrow\cpp\src\arrow/util/tracing.h(64): note: see reference to class template instantiation 'std::unique_ptr<arrow::util::tracing::Span::Impl,std::default_delete<arrow::util::tracing::Span::Impl>>' being compiled
   [build] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\include\memory(3086): error C2338: can't delete an incomplete type
   [build] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\include\memory(3087): warning C4150: deletion of pointer to incomplete type 'arrow::internal::tracing::SpanImpl'; no destructor called
   [build] C:\Users\voltron\arrow\cpp\src\arrow/util/tracing.h(30): note: see declaration of 'arrow::internal::tracing::SpanImpl'
   ```
   
   I am able to get this to work if I change it to a `shared_ptr` instead of `unique_ptr`, but that's not actually a good idea. 
   
   This build is configured with `ARROW_WITH_OPENTELEMETRY=OFF` (there's a completely different set of errors if I turn it on).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org