You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ne...@apache.org on 2019/02/23 00:46:11 UTC
[incubator-pinot] branch disable_realtime_agg_if_mv_dimension
updated: Change todo to fixme
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a commit to branch disable_realtime_agg_if_mv_dimension
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/disable_realtime_agg_if_mv_dimension by this push:
new a1988ce Change todo to fixme
a1988ce is described below
commit a1988ce31d490e8c0420d58e4d308a5c063abc53
Author: Neha Pawar <np...@linkedin.com>
AuthorDate: Fri Feb 22 16:46:00 2019 -0800
Change todo to fixme
---
.../apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java b/pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
index 1447d10..1b554e8 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
@@ -334,7 +334,7 @@ public class MutableSegmentImpl implements MutableSegment {
Preconditions.checkState(_dictionaryMap.get(column) == null, "Updating metrics not supported with dictionary.");
FieldSpec.DataType dataType = metricSpec.getDataType();
- // TODO: this breaks for multi value metrics. https://github.com/apache/incubator-pinot/issues/3867
+ // FIXME: this breaks for multi value metrics. https://github.com/apache/incubator-pinot/issues/3867
switch (dataType) {
case INT:
indexReaderWriter.setInt(docId, (Integer) value + indexReaderWriter.getInt(docId));
@@ -670,7 +670,7 @@ public class MutableSegmentImpl implements MutableSegment {
int i = 0;
int[] dictIds = new int[_numKeyColumns]; // dimensions + time column.
- // TODO: this for loop breaks for multi value columns. https://github.com/apache/incubator-pinot/issues/3867
+ // FIXME: this for loop breaks for multi value dimensions. https://github.com/apache/incubator-pinot/issues/3867
for (String column : _schema.getDimensionNames()) {
dictIds[i++] = (Integer) dictIdMap.get(column);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org