You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/09/20 12:43:45 UTC
[I] Make it clearer that `RuntimeEnv::new()` is fallable [datafusion]
alamb opened a new issue, #12554:
URL: https://github.com/apache/datafusion/issues/12554
### Is your feature request related to a problem or challenge?
While working on https://github.com/datafusion-contrib/datafusion-dft it was not clear that [`RuntimeEnv::new()`](https://docs.rs/datafusion/latest/datafusion/execution/runtime_env/struct.RuntimeEnv.html#method.new) actually returns a `Result` as the typical rust convention is a function `new()` is infallable and a function like `try_new()` is fallable. While this isn't a big deal it was a small usability papercut
### Describe the solution you'd like
I would like `RuntimeEnv` to follow standard rust conventions to make it easier to use
### Describe alternatives you've considered
I suggest:
1. Deprecating [`RuntimeEnv::new()`](https://docs.rs/datafusion/latest/datafusion/execution/runtime_env/struct.RuntimeEnv.html#method.new)
2. Add a new function `RuntimeEnv::try_new()` that does the same thing
3. Update all the datafusion code to use `try_new` instead
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Make it clearer that `RuntimeEnv::new()` is fallable [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #12554:
URL: https://github.com/apache/datafusion/issues/12554#issuecomment-2363653603
I think this is a good first issue as it is clearly described and straightforward to implement. It would be a good introduction to DataFusion I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Make it clearer that `RuntimeEnv::new()` is fallable [datafusion]
Posted by "OussamaSaoudi (via GitHub)" <gi...@apache.org>.
OussamaSaoudi commented on issue #12554:
URL: https://github.com/apache/datafusion/issues/12554#issuecomment-2365024042
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Make it clearer that `RuntimeEnv::new()` is fallable [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #12554: Make it clearer that `RuntimeEnv::new()` is fallable
URL: https://github.com/apache/datafusion/issues/12554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Make it clearer that `RuntimeEnv::new()` is fallable [datafusion]
Posted by "OussamaSaoudi (via GitHub)" <gi...@apache.org>.
OussamaSaoudi commented on issue #12554:
URL: https://github.com/apache/datafusion/issues/12554#issuecomment-2365022670
I'd like to take this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org