You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/15 06:14:37 UTC

[GitHub] [trafficserver] masaori335 commented on a change in pull request #7237: Fix bad HTTP/2 post client causing stuck HttpSM

masaori335 commented on a change in pull request #7237:
URL: https://github.com/apache/trafficserver/pull/7237#discussion_r505188928



##########
File path: proxy/http/HttpTunnel.cc
##########
@@ -1332,6 +1332,9 @@ HttpTunnel::consumer_handler(int event, HttpTunnelConsumer *c)
     if (c->producer && c->producer->handler_state == 0) {
       if (event == VC_EVENT_WRITE_COMPLETE) {
         c->producer->handler_state = HTTP_SM_POST_SUCCESS;
+        // If the consumer completed, presumably the producer successfully read and is done
+        c->producer->read_success = true;

Review comment:
       Note: This seems the key change, forcing to make the producer done on the `VC_EVENT_WRITE_COMPLETE` event.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org