You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/21 13:59:42 UTC
[GitHub] [hive] szlta opened a new pull request #1288: HIVE-23198
szlta opened a new pull request #1288:
URL: https://github.com/apache/hive/pull/1288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta merged pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
szlta merged pull request #1288:
URL: https://github.com/apache/hive/pull/1288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459296602
##########
File path: llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestCacheContentsTracker.java
##########
@@ -124,7 +125,7 @@ public void testCacheTagComparison() {
@Test
public void testEncodingDecoding() throws Exception {
- Map<String, String> partDescs = new HashMap<>();
+ LinkedHashMap<String, String> partDescs = new LinkedHashMap<>();
Review comment:
Could you please explain why we need LinkedHashMap?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
szlta commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459345582
##########
File path: llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestCacheContentsTracker.java
##########
@@ -124,7 +125,7 @@ public void testCacheTagComparison() {
@Test
public void testEncodingDecoding() throws Exception {
- Map<String, String> partDescs = new HashMap<>();
+ LinkedHashMap<String, String> partDescs = new LinkedHashMap<>();
Review comment:
That's because (nested) partition specification (e.g. p1=v11,p2=v12) has to be sorted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459369843
##########
File path: llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestCacheContentsTracker.java
##########
@@ -124,7 +125,7 @@ public void testCacheTagComparison() {
@Test
public void testEncodingDecoding() throws Exception {
- Map<String, String> partDescs = new HashMap<>();
+ LinkedHashMap<String, String> partDescs = new LinkedHashMap<>();
Review comment:
Got it! Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459294566
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
}
/**
- * Match a CacheTag to this eviction request.
+ * Match a CacheTag to this eviction request. Must only be used on LLAP side only, where the received request may
Review comment:
I do not get this comment. "request may only contain one information for one DB".
Could you please ellaborate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
szlta commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459412018
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
}
/**
- * Match a CacheTag to this eviction request.
+ * Match a CacheTag to this eviction request. Must only be used on LLAP side only, where the received request may
Review comment:
This Request class is used on HS2 side too, and there it may contain multiple DBs, hence there is no such 'general' restriction in this class. Although we're not doing this right now, but It's not impossible to call this method while we have multiple DBs, that's why the javadoc details the restriction on this method only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459294566
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
}
/**
- * Match a CacheTag to this eviction request.
+ * Match a CacheTag to this eviction request. Must only be used on LLAP side only, where the received request may
Review comment:
I do not get this comment. "request may only contain one information for one DB".
Could you please elaborate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459413654
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
}
/**
- * Match a CacheTag to this eviction request.
+ * Match a CacheTag to this eviction request. Must only be used on LLAP side only, where the received request may
Review comment:
Thanks for the clarification!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
szlta commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459347299
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
}
/**
- * Match a CacheTag to this eviction request.
+ * Match a CacheTag to this eviction request. Must only be used on LLAP side only, where the received request may
Review comment:
Proactive eviction requests are on a per DB basis: https://github.com/apache/hive/blob/master/llap-common/src/protobuf/LlapDaemonProtocol.proto#L234-L238
This comment is just a heads-up of that fact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1288: HIVE-23198
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459371170
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
}
/**
- * Match a CacheTag to this eviction request.
+ * Match a CacheTag to this eviction request. Must only be used on LLAP side only, where the received request may
Review comment:
Why is this checked here, and not at construction time, or when we receive / parse the request? This seems a little awkward for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org