You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Prasanna Santhanam <Pr...@citrix.com> on 2013/02/13 14:06:18 UTC

Review Request: CLOUDSTACK-1201: fix for failed to create ssh key for cloud

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9424/
-----------------------------------------------------------

Review request for cloudstack and Hugo Trippaers.


Description
-------

   packaging: rpm setting the homedir of user cloud
    
    cloud.spec changed to fix the packaging issue for user cloud. cloud has
    homedir set to /var/cloudstack/management after this fix.
    


This addresses bug CLOUDSTACK-1201.


Diffs
-----

  packaging/centos63/cloud.spec 7a740a6 

Diff: https://reviews.apache.org/r/9424/diff/


Testing
-------

deployed the package on to fresh centos 6.3 VM and private key generates successfully as well as 8096 port opens up after  restart of cloudstack-management


Thanks,

Prasanna Santhanam


Re: Review Request: CLOUDSTACK-1201: fix for failed to create ssh key for cloud

Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9424/#review16523
-----------------------------------------------------------


We'd probably want to account for upgrades as well, in changing /var/lib/cloud to /var/cloudstack. Not to mention any references to /var/lib/cloud in the code.

- Marcus Sorensen


On Feb. 13, 2013, 1:06 p.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9424/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 1:06 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
>    packaging: rpm setting the homedir of user cloud
>     
>     cloud.spec changed to fix the packaging issue for user cloud. cloud has
>     homedir set to /var/cloudstack/management after this fix.
>     
> 
> 
> This addresses bug CLOUDSTACK-1201.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 7a740a6 
> 
> Diff: https://reviews.apache.org/r/9424/diff/
> 
> 
> Testing
> -------
> 
> deployed the package on to fresh centos 6.3 VM and private key generates successfully as well as 8096 port opens up after  restart of cloudstack-management
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>


Re: Review Request: CLOUDSTACK-1201: fix for failed to create ssh key for cloud

Posted by Marcus Sorensen <sh...@gmail.com>.

> On Feb. 13, 2013, 8:31 p.m., Marcus Sorensen wrote:
> > Ship It!

I went ahead and included this change in a few other reference deletions to /var/lib/cloud, tested and seems to fix several issues. The only ones left are the debian-related ones, and I wasn't sure if they were accounting for it elsewhere in the packaging. Probably needs to be fixed there as well.


- Marcus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9424/#review16527
-----------------------------------------------------------


On Feb. 13, 2013, 1:06 p.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9424/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 1:06 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
>    packaging: rpm setting the homedir of user cloud
>     
>     cloud.spec changed to fix the packaging issue for user cloud. cloud has
>     homedir set to /var/cloudstack/management after this fix.
>     
> 
> 
> This addresses bug CLOUDSTACK-1201.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 7a740a6 
> 
> Diff: https://reviews.apache.org/r/9424/diff/
> 
> 
> Testing
> -------
> 
> deployed the package on to fresh centos 6.3 VM and private key generates successfully as well as 8096 port opens up after  restart of cloudstack-management
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>


Re: Review Request: CLOUDSTACK-1201: fix for failed to create ssh key for cloud

Posted by Prasanna Santhanam <Pr...@citrix.com>.

> On Feb. 13, 2013, 8:31 p.m., Marcus Sorensen wrote:
> > Ship It!
> 
> Marcus Sorensen wrote:
>     I went ahead and included this change in a few other reference deletions to /var/lib/cloud, tested and seems to fix several issues. The only ones left are the debian-related ones, and I wasn't sure if they were accounting for it elsewhere in the packaging. Probably needs to be fixed there as well.

Thanks I noticed the debian postinst as well. It appears to be a WIP so will wait on instructions from Wido and Noa. Closing the review.


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9424/#review16527
-----------------------------------------------------------


On Feb. 13, 2013, 1:06 p.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9424/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 1:06 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
>    packaging: rpm setting the homedir of user cloud
>     
>     cloud.spec changed to fix the packaging issue for user cloud. cloud has
>     homedir set to /var/cloudstack/management after this fix.
>     
> 
> 
> This addresses bug CLOUDSTACK-1201.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 7a740a6 
> 
> Diff: https://reviews.apache.org/r/9424/diff/
> 
> 
> Testing
> -------
> 
> deployed the package on to fresh centos 6.3 VM and private key generates successfully as well as 8096 port opens up after  restart of cloudstack-management
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>


Re: Review Request: CLOUDSTACK-1201: fix for failed to create ssh key for cloud

Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9424/#review16527
-----------------------------------------------------------

Ship it!


Ship It!

- Marcus Sorensen


On Feb. 13, 2013, 1:06 p.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9424/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 1:06 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
>    packaging: rpm setting the homedir of user cloud
>     
>     cloud.spec changed to fix the packaging issue for user cloud. cloud has
>     homedir set to /var/cloudstack/management after this fix.
>     
> 
> 
> This addresses bug CLOUDSTACK-1201.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 7a740a6 
> 
> Diff: https://reviews.apache.org/r/9424/diff/
> 
> 
> Testing
> -------
> 
> deployed the package on to fresh centos 6.3 VM and private key generates successfully as well as 8096 port opens up after  restart of cloudstack-management
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>


Re: Review Request: CLOUDSTACK-1201: fix for failed to create ssh key for cloud

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9424/#review18049
-----------------------------------------------------------


Commit ebafcf826b2506e779c8de8887d867ca4e0306bf in branch refs/heads/gslb-wip from Marcus Sorensen <ma...@betterservers.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=ebafcf8 ]

CLOUDSTACK-1201 - Fix update to cloud user's home dir on mgmt
    server. It was printing a meaningless failure if the cloud
    user's home dir didn't need to be updated.

Signed-off-by: Marcus Sorensen <ma...@betterservers.com> 1362809648 -0700


- ASF Subversion and Git Services


On Feb. 13, 2013, 1:06 p.m., Prasanna Santhanam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9424/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 1:06 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
>    packaging: rpm setting the homedir of user cloud
>     
>     cloud.spec changed to fix the packaging issue for user cloud. cloud has
>     homedir set to /var/cloudstack/management after this fix.
>     
> 
> 
> This addresses bug CLOUDSTACK-1201.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 7a740a6 
> 
> Diff: https://reviews.apache.org/r/9424/diff/
> 
> 
> Testing
> -------
> 
> deployed the package on to fresh centos 6.3 VM and private key generates successfully as well as 8096 port opens up after  restart of cloudstack-management
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>