You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/05/18 14:22:24 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #2696] [TEST] Stop NoopServer should not throw exception
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 5585dd01b [KYUUBI #2696] [TEST] Stop NoopServer should not throw exception
5585dd01b is described below
commit 5585dd01bb91a955c9c28498737b2e245b686ef5
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Wed May 18 22:22:13 2022 +0800
[KYUUBI #2696] [TEST] Stop NoopServer should not throw exception
### _Why are the changes needed?_
Stop NoopServer should not throw exception
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #2696 from pan3793/noop.
Closes #2696
02c98503 [Cheng Pan] [TEST] Stop NoopServer should not throw exception
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.../src/test/scala/org/apache/kyuubi/service/AbstractNoopServer.scala | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kyuubi-common/src/test/scala/org/apache/kyuubi/service/AbstractNoopServer.scala b/kyuubi-common/src/test/scala/org/apache/kyuubi/service/AbstractNoopServer.scala
index 4f74bea9d..36e1fa182 100644
--- a/kyuubi-common/src/test/scala/org/apache/kyuubi/service/AbstractNoopServer.scala
+++ b/kyuubi-common/src/test/scala/org/apache/kyuubi/service/AbstractNoopServer.scala
@@ -17,8 +17,6 @@
package org.apache.kyuubi.service
-import org.apache.kyuubi.KyuubiException
-
abstract class AbstractNoopServer(name: String) extends Serverable(name) {
override val backendService = new NoopBackendService
@@ -33,6 +31,6 @@ abstract class AbstractNoopServer(name: String) extends Serverable(name) {
}
override protected def stopServer(): Unit = {
- throw new KyuubiException("no need to stop me")
+ logger.info(s"$name stopped.")
}
}