You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/10/15 09:03:43 UTC

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #417: [IOTDB-234] Refactor TsFile storage on HDFS

samperson1997 commented on a change in pull request #417: [IOTDB-234] Refactor TsFile storage on HDFS
URL: https://github.com/apache/incubator-iotdb/pull/417#discussion_r334832198
 
 

 ##########
 File path: tsfile/src/main/java/org/apache/iotdb/tsfile/fileSystem/FileInputFactory.java
 ##########
 @@ -19,33 +19,39 @@
 
 package org.apache.iotdb.tsfile.fileSystem;
 
+import java.io.IOException;
+import java.lang.reflect.InvocationTargetException;
+import java.nio.file.Paths;
 import org.apache.iotdb.tsfile.common.conf.TSFileDescriptor;
 import org.apache.iotdb.tsfile.read.reader.DefaultTsFileInput;
 import org.apache.iotdb.tsfile.read.reader.TsFileInput;
-import org.apache.iotdb.tsfile.write.writer.TsFileIOWriter;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.IOException;
-import java.nio.file.Paths;
-
 public enum FileInputFactory {
 
 Review comment:
   Should I separate these different factories into three packages? like `fsFactory`, `fileInputFactory` and `fileOutputFactory`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services