You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hivemall.apache.org by Koji Sekiguchi <ko...@rondhuit.com> on 2018/11/07 02:37:53 UTC

lacking stuff in NOTICE file?

Hi,

I saw a source file that looks third-party work:

https://github.com/apache/incubator-hivemall/blob/master/core/src/main/java/hivemall/utils/codec/Base91.java

but doesn't appear in NOTICE file. Though I'm not sure we should always put such work
in NOTICE file by reading this:

https://www.apache.org/legal/src-headers.html#3party

but OpenNLP, which is a part of Apache top projects, uses NOTICE file to declare that
they use snowball stemmers (third-party work):

https://github.com/apache/opennlp/blob/master/NOTICE

Have committers/PMC members discussed about this when you imported the source code?

If not, I think we'd better put it in NOTICE file.

Thanks,

Koji

Re: lacking stuff in NOTICE file?

Posted by Makoto Yui <my...@apache.org>.

> In my understanding, NOTICE file should only include copyrights of SGA
> providers.

oops... Ditto to ASL licensed project with NOTICE file.

ASL license project without NOTICE file should be listed in the LICENSE file.

It's not mandatory (in my understanding) but we can eliminate some
duplicating ASL as seen in
https://markmail.org/message/oj5sohmdmciyt4me

Thanks,
Makoto

-- 
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

Re: lacking stuff in NOTICE file?

Posted by Koji Sekiguchi <ko...@rondhuit.com>.

Hi Yui-san,

I'm glad to know that you've already discussed it in the past.

And thank you for showing me the threads. They look good to me.

Koji


On 2018/11/07 12:03, Makoto Yui wrote:
> Thanks Koji for checking our NOTICE.
> 
> I did some discussion with Justin (IPMC chair) about NOTICE and
> LICENSE in the past in incubator-general in
> https://markmail.org/message/h7b7t3fg57cqp5pd
> 
> In my understanding, NOTICE file should only include copyrights of SGA
> providers.
> 
> And, showing copyrights in LICENSE is enough.
> https://github.com/apache/incubator-hivemall/blob/master/LICENSE#L237
> 
> Thanks,
> Makoto
> 2018年11月7日(水) 11:38 Koji Sekiguchi <ko...@rondhuit.com>:
>>
>> Hi,
>>
>> I saw a source file that looks third-party work:
>>
>> https://github.com/apache/incubator-hivemall/blob/master/core/src/main/java/hivemall/utils/codec/Base91.java
>>
>> but doesn't appear in NOTICE file. Though I'm not sure we should always put such work
>> in NOTICE file by reading this:
>>
>> https://www.apache.org/legal/src-headers.html#3party
>>
>> but OpenNLP, which is a part of Apache top projects, uses NOTICE file to declare that
>> they use snowball stemmers (third-party work):
>>
>> https://github.com/apache/opennlp/blob/master/NOTICE
>>
>> Have committers/PMC members discussed about this when you imported the source code?
>>
>> If not, I think we'd better put it in NOTICE file.
>>
>> Thanks,
>>
>> Koji
>

Re: lacking stuff in NOTICE file?

Posted by Makoto Yui <my...@apache.org>.

Thanks Koji for checking our NOTICE.

I did some discussion with Justin (IPMC chair) about NOTICE and
LICENSE in the past in incubator-general in
https://markmail.org/message/h7b7t3fg57cqp5pd

In my understanding, NOTICE file should only include copyrights of SGA
providers.

And, showing copyrights in LICENSE is enough.
https://github.com/apache/incubator-hivemall/blob/master/LICENSE#L237

Thanks,
Makoto
2018年11月7日(水) 11:38 Koji Sekiguchi <ko...@rondhuit.com>:
>
> Hi,
>
> I saw a source file that looks third-party work:
>
> https://github.com/apache/incubator-hivemall/blob/master/core/src/main/java/hivemall/utils/codec/Base91.java
>
> but doesn't appear in NOTICE file. Though I'm not sure we should always put such work
> in NOTICE file by reading this:
>
> https://www.apache.org/legal/src-headers.html#3party
>
> but OpenNLP, which is a part of Apache top projects, uses NOTICE file to declare that
> they use snowball stemmers (third-party work):
>
> https://github.com/apache/opennlp/blob/master/NOTICE
>
> Have committers/PMC members discussed about this when you imported the source code?
>
> If not, I think we'd better put it in NOTICE file.
>
> Thanks,
>
> Koji

-- 
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/