You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/15 02:33:39 UTC

[GitHub] [cloudstack-primate] utchoang opened a new pull request #711: FIX - Reduce max pagination from 500/page to 200/page

utchoang opened a new pull request #711:
URL: https://github.com/apache/cloudstack-primate/pull/711


   @rhtyd cc @svenvogel 
   Fixes #708 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #711: FIX - Reduce max pagination from 500/page to 200/page

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #711:
URL: https://github.com/apache/cloudstack-primate/pull/711#issuecomment-692456680


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #711: FIX - Reduce max pagination from 500/page to 200/page

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #711:
URL: https://github.com/apache/cloudstack-primate/pull/711


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #711: FIX - Reduce max pagination from 500/page to 200/page

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #711:
URL: https://github.com/apache/cloudstack-primate/pull/711#discussion_r488405615



##########
File path: src/views/network/IpAddressesTab.vue
##########
@@ -272,7 +272,7 @@ export default {
           errorMethod: () => {
             this.fetchData()
           },
-          loadingMessage: `${this.$t('label.acquiring.ip')} ${this.$t('label.for')} ${this.resource.name} ${this.$t('label.is.in.progress')}`,
+          loadingMessage: `${this.$t('label.acquiring.ip')}} ${this.$t('label.for')} ${this.resource.name} ${this.$t('label.is.in.progress')}}`,

Review comment:
       @utchoang Could you fix the extra braces ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #711: FIX - Reduce max pagination from 500/page to 200/page

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #711:
URL: https://github.com/apache/cloudstack-primate/pull/711#issuecomment-692459971


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/711 (JID-3472)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #711: FIX - Reduce max pagination from 500/page to 200/page

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #711:
URL: https://github.com/apache/cloudstack-primate/pull/711#issuecomment-692456421


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org