[GitHub] [geode-native] echobravopapa commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test

[GitBox <gi...@apache.org>]

echobravopapa commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r485715946



##########
File path: clicache/acceptance-test/SNITests.cs
##########
@@ -34,6 +34,8 @@ public class SNITests : TestBase, IDisposable
 
         public SNITests(ITestOutputHelper testOutputHelper) : base(testOutputHelper)
         {
+			Dispose();

Review comment:
       does this make sense for C# language?  using the `Dispose` method...?

##########
File path: cppcache/acceptance-test/SNITest.cpp
##########
@@ -52,6 +52,8 @@ class SNITest : public ::testing::Test {
   ~SNITest() override = default;
 
   void SetUp() override {
+    TearDown();

Review comment:
       same thing here... `gtest` uses `TearDown` as a special method... I wonder if it would be better to have a utility method for both that is called from the constructor in C# and `SetUp` in this test...  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org