You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/26 12:34:32 UTC
[GitHub] [spark] beliefer opened a new pull request #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
beliefer opened a new pull request #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708
### What changes were proposed in this pull request?
1.Add version information to the configuration of `R`.
2.Update the docs of `R`.
I sorted out some information show below.
Item name | Since version | JIRA ID | Commit ID | Note
-- | -- | -- | -- | --
spark.r.backendConnectionTimeout | 2.1.0 | SPARK-17919 | 2881a2d1d1a650a91df2c6a01275eba14a43b42a#diff-025470e1b7094d7cf4a78ea353fb3981 |
spark.r.numRBackendThreads | 1.4.0 | SPARK-8282 | 28e8a6ea65fd08ab9cefc4d179d5c66ffefd3eb4#diff-697f7f2fc89808e0113efc71ed235db2 |
spark.r.heartBeatInterval | 2.1.0 | SPARK-17919 | 2881a2d1d1a650a91df2c6a01275eba14a43b42a#diff-fe903bf14db371aa320b7cc516f2463c |
spark.sparkr.r.command | 1.5.3 | SPARK-10971 | 9695f452e86a88bef3bcbd1f3c0b00ad9e9ac6e1#diff-025470e1b7094d7cf4a78ea353fb3981 |
spark.r.command | 1.5.3 | SPARK-10971 | 9695f452e86a88bef3bcbd1f3c0b00ad9e9ac6e1#diff-025470e1b7094d7cf4a78ea353fb3981 |
### Why are the changes needed?
Supplemental configuration version information.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Exists UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591487392
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591487412
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118973/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#discussion_r384464307
##########
File path: core/src/main/scala/org/apache/spark/internal/config/R.scala
##########
@@ -19,22 +19,27 @@ package org.apache.spark.internal.config
private[spark] object R {
val R_BACKEND_CONNECTION_TIMEOUT = ConfigBuilder("spark.r.backendConnectionTimeout")
+ .version("2.1.0")
.intConf
.createWithDefault(6000)
val R_NUM_BACKEND_THREADS = ConfigBuilder("spark.r.numRBackendThreads")
+ .version("1.4.0")
.intConf
.createWithDefault(2)
val R_HEARTBEAT_INTERVAL = ConfigBuilder("spark.r.heartBeatInterval")
+ .version("2.1.0")
.intConf
.createWithDefault(100)
val SPARKR_COMMAND = ConfigBuilder("spark.sparkr.r.command")
+ .version("1.5.3")
Review comment:
SPARK-10971, commit ID: 9695f452e86a88bef3bcbd1f3c0b00ad9e9ac6e1#diff-025470e1b7094d7cf4a78ea353fb3981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591487412
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118973/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591487392
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591405347
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#discussion_r384464477
##########
File path: core/src/main/scala/org/apache/spark/internal/config/R.scala
##########
@@ -19,22 +19,27 @@ package org.apache.spark.internal.config
private[spark] object R {
val R_BACKEND_CONNECTION_TIMEOUT = ConfigBuilder("spark.r.backendConnectionTimeout")
+ .version("2.1.0")
.intConf
.createWithDefault(6000)
val R_NUM_BACKEND_THREADS = ConfigBuilder("spark.r.numRBackendThreads")
+ .version("1.4.0")
.intConf
.createWithDefault(2)
val R_HEARTBEAT_INTERVAL = ConfigBuilder("spark.r.heartBeatInterval")
+ .version("2.1.0")
.intConf
.createWithDefault(100)
val SPARKR_COMMAND = ConfigBuilder("spark.sparkr.r.command")
+ .version("1.5.3")
.stringConf
.createWithDefault("Rscript")
val R_COMMAND = ConfigBuilder("spark.r.command")
+ .version("1.5.3")
Review comment:
SPARK-10971, commit ID: 9695f452e86a88bef3bcbd1f3c0b00ad9e9ac6e1#diff-025470e1b7094d7cf4a78ea353fb3981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591405347
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591405366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23721/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591737729
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591404909
**[Test build #118973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118973/testReport)** for PR 27708 at commit [`cc0203e`](https://github.com/apache/spark/commit/cc0203edd6c7ac8de39b18be3fad23b718bab23d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#discussion_r384463769
##########
File path: core/src/main/scala/org/apache/spark/internal/config/R.scala
##########
@@ -19,22 +19,27 @@ package org.apache.spark.internal.config
private[spark] object R {
val R_BACKEND_CONNECTION_TIMEOUT = ConfigBuilder("spark.r.backendConnectionTimeout")
+ .version("2.1.0")
Review comment:
SPARK-17919, commit ID: 2881a2d1d1a650a91df2c6a01275eba14a43b42a#diff-025470e1b7094d7cf4a78ea353fb3981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#discussion_r384464117
##########
File path: core/src/main/scala/org/apache/spark/internal/config/R.scala
##########
@@ -19,22 +19,27 @@ package org.apache.spark.internal.config
private[spark] object R {
val R_BACKEND_CONNECTION_TIMEOUT = ConfigBuilder("spark.r.backendConnectionTimeout")
+ .version("2.1.0")
.intConf
.createWithDefault(6000)
val R_NUM_BACKEND_THREADS = ConfigBuilder("spark.r.numRBackendThreads")
+ .version("1.4.0")
.intConf
.createWithDefault(2)
val R_HEARTBEAT_INTERVAL = ConfigBuilder("spark.r.heartBeatInterval")
+ .version("2.1.0")
Review comment:
SPARK-17919, commit ID: 2881a2d1d1a650a91df2c6a01275eba14a43b42a#diff-fe903bf14db371aa320b7cc516f2463c
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591766679
@HyukjinKwon Thanks for your help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591405366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23721/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27708: [SPARK-30910][CORE][DOC]
Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591404909
**[Test build #118973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118973/testReport)** for PR 27708 at commit [`cc0203e`](https://github.com/apache/spark/commit/cc0203edd6c7ac8de39b18be3fad23b718bab23d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27708:
[SPARK-30910][CORE][DOC] Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#discussion_r384463925
##########
File path: core/src/main/scala/org/apache/spark/internal/config/R.scala
##########
@@ -19,22 +19,27 @@ package org.apache.spark.internal.config
private[spark] object R {
val R_BACKEND_CONNECTION_TIMEOUT = ConfigBuilder("spark.r.backendConnectionTimeout")
+ .version("2.1.0")
.intConf
.createWithDefault(6000)
val R_NUM_BACKEND_THREADS = ConfigBuilder("spark.r.numRBackendThreads")
+ .version("1.4.0")
Review comment:
SPARK-8282, commit ID: 28e8a6ea65fd08ab9cefc4d179d5c66ffefd3eb4#diff-697f7f2fc89808e0113efc71ed235db2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27708: [SPARK-30910][CORE][DOC]
Add version information to the configuration of R
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27708: [SPARK-30910][CORE][DOC] Add version information to the configuration of R
URL: https://github.com/apache/spark/pull/27708#issuecomment-591486273
**[Test build #118973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118973/testReport)** for PR 27708 at commit [`cc0203e`](https://github.com/apache/spark/commit/cc0203edd6c7ac8de39b18be3fad23b718bab23d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org