You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2019/04/24 14:38:44 UTC
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request
#492: DISPATCH-1310: refactor the receive handler code
ganeshmurthy commented on a change in pull request #492: DISPATCH-1310: refactor the receive handler code
URL: https://github.com/apache/qpid-dispatch/pull/492#discussion_r278159983
##########
File path: src/container.c
##########
@@ -642,8 +641,8 @@ void qd_container_handle_event(qd_container_t *container, pn_event_t *event,
delivery = pn_event_delivery(event);
pn_link = pn_event_link(event);
- if (pn_link_is_receiver(pn_link))
- do_receive(delivery);
+ if (pn_delivery_readable(delivery))
Review comment:
If you look at commit 417975e17406dcc48a648d9fc6da38651a4ff956, the pn_delivery_readable was changed to pn_link_is_receiver. Please talk to @ted-ross about this just to make sure we don't have a regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org