[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1843: make/clean: clean the OBJ directly if declare in subdirectory

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491471878



##########
File path: tools/Config.mk
##########
@@ -458,7 +458,8 @@ define CLEAN
 endef
 else
 define CLEAN
-	$(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+	$(call DELFILE, $(wildcard $(foreach obj, $(OBJS), $(addsuffix /$(obj), $(subst :, ,$(VPATH))))))
+	$(call DELFILE, *$(OBJEXT) *$(LIBEXT) *~ .*.swp)

Review comment:
       > hi, I'm testing the approach of just cleaning $(OBJS) and $(BIN) like:
   > 
   > ```
   > define CLEAN
   >         $(Q) rm -f *~ .*.swp $(OBJS) $(BIN)
   > endef
   > ```
   
   Doesn't this have the possibility of doing a back CLEAN after a reconfiguration?  The OBJS many not be the same after a reconfiguration as they were before the reconfiguration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org