[GitHub] [sling-org-apache-sling-scripting-core] kwin edited a comment on pull request #8: SLING-10584 log an info message if adding bindings takes more than 1 msec

[GitBox <gi...@apache.org>]

kwin edited a comment on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/8#issuecomment-875446143


   I think this deserves a more general discussion about which SPI calls bound to a request should be measured and lead to a warning in case they take too long. IMHO there are dozens of places with which custom code can make request execution much slower. I don't see a particular need to just measure execution of `BindingsValuesProvider` and emit warnings. What about servlet filters/JSP tags/HTL plugins/getter methods of beans/.....?
   
   Also for special bindings providers it may be totally fine if they take more than 1ms (if the bindings are used rarely). Then this output would just pollute the log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org