You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Rajat Phull <rp...@nvidia.com> on 2016/12/08 07:09:25 UTC
Re: Review Request 50523: Updated docker recovery to account for GPU
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50523/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 7:09 a.m.)
Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama Ditya.
Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795
Repository: mesos
Description
-------
Updated docker recovery to account for GPU resources.
Diffs (updated)
-----
src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d
src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c
src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16
Diff: https://reviews.apache.org/r/50523/diff/
Testing
-------
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery" make -j check
Thanks,
Rajat Phull
Re: Review Request 50523: Updated docker recovery to account for GPU
resources.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50523/#review167532
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Dec. 20, 2016, 7:53 a.m., Rajat Phull wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50523/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 7:53 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama Ditya.
>
>
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docker recovery to account for GPU resources.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d
> src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c
> src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16
>
>
> Diff: https://reviews.apache.org/r/50523/diff/6/
>
>
> Testing
> -------
>
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery" make -j check
>
>
> Thanks,
>
> Rajat Phull
>
>
Re: Review Request 50523: Updated docker recovery to account for GPU
resources.
Posted by Rajat Phull <rp...@nvidia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50523/
-----------------------------------------------------------
(Updated Dec. 20, 2016, 7:53 a.m.)
Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama Ditya.
Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795
Repository: mesos
Description
-------
Updated docker recovery to account for GPU resources.
Diffs (updated)
-----
src/slave/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d
src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c
src/tests/containerizer/docker_containerizer_tests.cpp c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16
Diff: https://reviews.apache.org/r/50523/diff/
Testing
-------
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery" make -j check
Thanks,
Rajat Phull