You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2023/03/02 10:32:35 UTC
[shardingsphere] branch master updated: Fix grammar for mysql begin statement (#24423)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 4d133a4c999 Fix grammar for mysql begin statement (#24423)
4d133a4c999 is described below
commit 4d133a4c999739a5cfa4db0b61f1071351f26242
Author: jiangtao <ji...@gmail.com>
AuthorDate: Thu Mar 2 18:32:18 2023 +0800
Fix grammar for mysql begin statement (#24423)
---
sql-parser/dialect/mysql/src/main/antlr4/imports/mysql/TCLStatement.g4 | 2 +-
test/it/parser/src/main/resources/case/tcl/begin-transaction.xml | 1 +
.../parser/src/main/resources/sql/supported/tcl/begin-transcation.xml | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/sql-parser/dialect/mysql/src/main/antlr4/imports/mysql/TCLStatement.g4 b/sql-parser/dialect/mysql/src/main/antlr4/imports/mysql/TCLStatement.g4
index 05916cb4865..9e8393a1c2a 100644
--- a/sql-parser/dialect/mysql/src/main/antlr4/imports/mysql/TCLStatement.g4
+++ b/sql-parser/dialect/mysql/src/main/antlr4/imports/mysql/TCLStatement.g4
@@ -28,7 +28,7 @@ setAutoCommit
;
beginTransaction
- : BEGIN | START TRANSACTION (transactionCharacteristic (COMMA_ transactionCharacteristic)*)?
+ : BEGIN WORK? | START TRANSACTION (transactionCharacteristic (COMMA_ transactionCharacteristic)*)?
;
transactionCharacteristic
diff --git a/test/it/parser/src/main/resources/case/tcl/begin-transaction.xml b/test/it/parser/src/main/resources/case/tcl/begin-transaction.xml
index 03acb896b54..024964d376c 100644
--- a/test/it/parser/src/main/resources/case/tcl/begin-transaction.xml
+++ b/test/it/parser/src/main/resources/case/tcl/begin-transaction.xml
@@ -18,6 +18,7 @@
<sql-parser-test-cases>
<begin-transaction sql-case-id="begin" />
+ <begin-transaction sql-case-id="begin_work" />
<begin-transaction sql-case-id="begin_transaction" />
<begin-transaction sql-case-id="begin_with_name" />
<begin-transaction sql-case-id="begin_with_variable_name" />
diff --git a/test/it/parser/src/main/resources/sql/supported/tcl/begin-transcation.xml b/test/it/parser/src/main/resources/sql/supported/tcl/begin-transcation.xml
index cb70e1efdbd..90446ea6985 100644
--- a/test/it/parser/src/main/resources/sql/supported/tcl/begin-transcation.xml
+++ b/test/it/parser/src/main/resources/sql/supported/tcl/begin-transcation.xml
@@ -18,6 +18,7 @@
<sql-cases>
<sql-case id="begin" value="BEGIN" db-types="MySQL,PostgreSQL,openGauss" />
+ <sql-case id="begin_work" value="BEGIN WORK" db-types="MySQL" />
<sql-case id="begin_transaction" value="BEGIN TRANSACTION" db-types="SQLServer,PostgreSQL,openGauss" />
<sql-case id="begin_with_name" value="BEGIN TRANSACTION transaction1" db-types="SQLServer" />
<sql-case id="begin_with_variable_name" value="BEGIN TRANSACTION @TranName" db-types="SQLServer" />