[PR] NIFI-15971 Add Allow Missing Directory option to ListFile and GetFile [nifi]

["rakesh-rsky (via GitHub)" <gi...@apache.org>]

rakesh-rsky opened a new pull request, #11337:
URL: https://github.com/apache/nifi/pull/11337

   Add ALLOW_MISSING_DIRECTORY property (default false) to both ListFile and GetFile. When enabled, processors bypass directory existence validation at flow startup and handle a missing directory gracefully at runtime - logging a warning and yielding/returning an empty listing instead of failing.
   
   This allows MiNiFi and NiFi flows to start successfully when the configured input directory does not yet exist, which is a common deployment scenario.
   
   Changes:
   - ListFile: replace createDirectoryExistsValidator with NON_BLANK_VALIDATOR, add customValidate() override using AbstractListProcessor extension point, return empty listing with warning when directory is missing at runtime
   - GetFile: same validator change, add customValidate(), yield with warning when directory is missing at runtime, fix performListing() to check existence before checking permissions (avoids IllegalStateException on missing dir)
   - Add tests for both valid/invalid configurations and runtime empty-listing behavior when ALLOW_MISSING_DIRECTORY is true
   
   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-15971](https://issues.apache.org/jira/browse/NIFI-15971)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - Pull Request based on current revision of the `main` branch
   - Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15971 Add Allow Missing Directory option to ListFile and GetFile [nifi]

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory closed pull request #11337: NIFI-15971 Add Allow Missing Directory option to ListFile and GetFile
URL: https://github.com/apache/nifi/pull/11337


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15971 Add Allow Missing Directory option to ListFile and GetFile [nifi]

["mosermw (via GitHub)" <gi...@apache.org>]

mosermw commented on PR #11337:
URL: https://github.com/apache/nifi/pull/11337#issuecomment-4708833805

   -1 on the concept of this change until someone can convince me otherwise.
   
   Validators provide a very specific and valuable purpose during component configuration.  The "Input Directory" property of ListFile and GetFile is especially important to configure correctly, and that notification should happen during configuration.  An existing flow with these processors running can be started and will simply stop dataflow through these processors until the input directory does exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org