You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/03/31 09:57:45 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request, #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
ppalaga opened a new pull request, #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729
Fix https://github.com/apache/camel-quarkus/issues/4684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#discussion_r1154476125
##########
extensions/datasonnet/runtime/src/main/resources/META-INF/quarkus-extension.yaml:
##########
@@ -23,6 +23,7 @@
---
name: "Camel DataSonnet"
description: "To use DataSonnet scripts for message transformations"
+icon-url: "https://camel.apache.org/_/img/logo-d-f21b25ba38.svg"
Review Comment:
Nice catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#issuecomment-1491927567
> > will this be generated automatically when adding a new extension?
>
> Yes it is driven by the template in [tooling/create-extension-templates/quarkus-extension.yaml#L26](https://github.com/apache/camel-quarkus/blob/main/tooling/create-extension-templates/quarkus-extension.yaml#L26)
Awesome! Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#issuecomment-1491897348
@ppalaga thanks
Sorry another thing is missing, the new icon-url is missing in this file : https://github.com/apache/camel-quarkus/blob/main/extensions/xmlsecurity/runtime/src/main/resources/META-INF/quarkus-extension.yaml
BTW, will this be generated automatically when adding a new extension?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#issuecomment-1491922951
> Sorry another thing is missing, the new icon-url is missing in this file : https://github.com/apache/camel-quarkus/blob/main/extensions/xmlsecurity/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Fixed along with a few other small things.
> will this be generated automatically when adding a new extension?
Yes it is driven by the template in [tooling/create-extension-templates/quarkus-extension.yaml#L26](https://github.com/apache/camel-quarkus/blob/main/tooling/create-extension-templates/quarkus-extension.yaml#L26)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#issuecomment-1491887081
> > @ppalaga Can you please update this migration guide https://camel.apache.org/camel-quarkus/3.0.x/migration-guide/3.0.0.html
>
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#issuecomment-1491881678
@jamesnetherton the failure in JDBC is the intermittent one you are solving right now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#issuecomment-1491881972
> @ppalaga Can you please update this migration guide https://camel.apache.org/camel-quarkus/3.0.x/migration-guide/3.0.0.html
Thanks for the reminder, let me do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4729: Upgrade to quarkus-cxf 2.0.0.Alpha5, Add back XML Security Sign
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4729:
URL: https://github.com/apache/camel-quarkus/pull/4729#issuecomment-1491710178
@ppalaga Can you please update this migration guide https://camel.apache.org/camel-quarkus/3.0.x/migration-guide/3.0.0.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org