You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@singa.apache.org by wa...@apache.org on 2015/06/15 07:27:24 UTC

svn commit: r1685499 - /incubator/singa/site/trunk/content/markdown/develop/contribute-code.md

Author: wangwei
Date: Mon Jun 15 05:27:24 2015
New Revision: 1685499

URL: http://svn.apache.org/r1685499
Log:
update commit message format

Modified:
    incubator/singa/site/trunk/content/markdown/develop/contribute-code.md

Modified: incubator/singa/site/trunk/content/markdown/develop/contribute-code.md
URL: http://svn.apache.org/viewvc/incubator/singa/site/trunk/content/markdown/develop/contribute-code.md?rev=1685499&r1=1685498&r2=1685499&view=diff
==============================================================================
--- incubator/singa/site/trunk/content/markdown/develop/contribute-code.md (original)
+++ incubator/singa/site/trunk/content/markdown/develop/contribute-code.md Mon Jun 15 05:27:24 2015
@@ -28,10 +28,9 @@ your own Github account.
  branch).
 
 * Open a pull request against the master branch of apache/incubator-singa.
-The PR title should be of the form [SINGA-xxxx] Title, where
+The PR title should be of the form SINGA-xxxx Title, where
 SINGA-xxxx is the relevant JIRA number, and Title may be the JIRA's title or a
-more specific title describing the PR itself. The link to the JIRA should be
-provided. Detailed description can be copied from the JIRA.
+more specific title describing the PR itself, for example, "SINGA-6 Implement thread-safe singleton". Detailed description can be copied from the JIRA.
 Consider identifying committers or other contributors who have worked on the
 code being changed. Find the file(s) in Github and click "Blame" to see a
 line-by-line annotation of who changed the code last.  You can add @username in
@@ -39,5 +38,5 @@ the PR description to ping them immediat
 Please state that the contribution is your original work and that you license
 the work to the project under the project's open source license.
 
-* Wait for one committer to review the patch. Further commits (e.g., bug fix)
+* Wait for one committer to review and merge (do not use rebase) the patch. Further commits (e.g., bug fix)
 to your new branch will be added to this pull request automatically by Github.