You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/02/04 09:58:00 UTC
[jira] [Commented] (WW-5005) Struts2 convention plugin lacks Java
11 support
[ https://issues.apache.org/jira/browse/WW-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759727#comment-16759727 ]
ASF subversion and git services commented on WW-5005:
-----------------------------------------------------
Commit 13c517fc3c0b1442e24928671fe9f901e66c57fe in struts's branch refs/heads/struts-2-5-x from Yasser Zamani
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=13c517f ]
Merge branch 'struts-2-5-x' into WW-5005
> Struts2 convention plugin lacks Java 11 support
> -----------------------------------------------
>
> Key: WW-5005
> URL: https://issues.apache.org/jira/browse/WW-5005
> Project: Struts 2
> Issue Type: New Feature
> Components: Plugin - Convention
> Affects Versions: 2.5.20
> Reporter: Sebastian Götz
> Assignee: Yasser Zamani
> Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> As discussed in the mailing list, the convention plugin is uncapable of analysing web applications that have classes compiled with class versions higher than 52. This blocks users that compile their web app projects with Java 9, 10 or 11.
> Excerpt from the mailing list discussion:
> I have taken a look at the struts-2-5-x branch in github. There is a global property in the {{struts-parent}} of that defines the version for ASM:
> {{<asm.version>5.2</asm.version>}}
> The {{struts-master}} pom of the current github *master branch* has:
> {{<asm.version>7.0</asm.version>}}
> But when I look into {{DefaultClassFinder$InfoBuildingVisitor}} class (line 461) of the *master branch* there is still ASM 5 used:
> {{public class InfoBuildingVisitor extends ClassVisitor {}}
> {{ private Info info;}}
> {{ private ClassFinder classFinder;}}
> {{ public InfoBuildingVisitor(ClassFinder classFinder) {}}
> *{{super(Opcodes.ASM5);}}*
> {{ this.classFinder = classFinder;}}
> \{{ }}}
> So first step would be to change this coupling to ASM's version 7 API and check how this affects classes compiled with Java 8 or below.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)