You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/29 06:40:50 UTC

[GitHub] [incubator-superset] mistercrunch commented on issue #7032: Fetch charts with GET to benefit from browser cache and conditional requests

mistercrunch commented on issue #7032: Fetch charts with GET to benefit from browser cache and conditional requests
URL: https://github.com/apache/incubator-superset/pull/7032#issuecomment-496806083
 
 
   Found some other issues here that I wanted to raise ^^^
   
   Also I noticed that the big "merge" on `master` of this and much more stuff got actually done on a single commit instead of a proper merge 538776b47025f8ff97f293f943736cb3633b2702
   
   In the future, `lyftga` branches and the likes should be **merged**, not squashed and merged as we loose tons of history. For instance if we wanted to revert this PR, there's no single commit in master we can address, we'd have to revert all of 538776b47025f8ff97f293f943736cb3633b2702 or get really creative...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org