You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2019/06/06 23:17:07 UTC

[GitHub] [groovy] paulk-asert commented on a change in pull request #950: Add first batch of tests for @Generated. Relates to GROOVY-9164

paulk-asert commented on a change in pull request #950: Add first batch of tests for @Generated. Relates to GROOVY-9164
URL: https://github.com/apache/groovy/pull/950#discussion_r291406338
 
 

 ##########
 File path: src/test/groovy/generated/AbstractGeneratedAstTestCase.groovy
 ##########
 @@ -0,0 +1,60 @@
+package groovy.generated
+
+import groovy.transform.CompileStatic
+import groovy.transform.Generated
+
+import java.lang.reflect.Constructor
+import java.lang.reflect.Method
+
+/**
+ * @author Dmitry Vyazelenko
+ * @author Andres Almiray
 
 Review comment:
   Apache generally discourages explicit @author tags. They get out of date quickly, provide less info than git will already tell you and can sometimes discourage participation if certain files are perceived to belong to particular individuals rather than the whole community. I'd suggest removing them but add Dmitry as contributor in pomconfigurer,gradle - you are already there. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services