You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/15 09:31:08 UTC

[GitHub] [dolphinscheduler] davidzollo commented on a diff in pull request #12664: [Bug][API]edit workflow query resources list error.

davidzollo commented on code in PR #12664:
URL: https://github.com/apache/dolphinscheduler/pull/12664#discussion_r1022548800


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java:
##########
@@ -847,7 +847,12 @@ private boolean upload(User loginUser, String fullName, MultipartFile file, Reso
     @Override
     public Map<String, Object> queryResourceList(User loginUser, ResourceType type, String fullName) {
         Map<String, Object> result = new HashMap<>();
-
+        if (!PropertyUtils.getResUploadStartupState()) {
+            logger.error("Storage does not start up, resource upload startup state: {}.",
+                    PropertyUtils.getResUploadStartupState());

Review Comment:
   The error message should tell users like 'You need to set the resource storage in the file of common.properties.' 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org