You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nlpcraft.apache.org by ar...@apache.org on 2021/04/15 21:55:11 UTC
[incubator-nlpcraft] branch NLPCRAFT-287 updated: Code review.
This is an automated email from the ASF dual-hosted git repository.
aradzinski pushed a commit to branch NLPCRAFT-287
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git
The following commit(s) were added to refs/heads/NLPCRAFT-287 by this push:
new 83b3b6a Code review.
new 1900300 Merge branch 'NLPCRAFT-287' of https://github.com/apache/incubator-nlpcraft into NLPCRAFT-287
83b3b6a is described below
commit 83b3b6a349f6651ce94b8bc31081de2a181701f7
Author: Aaron Radzinzski <ar...@datalingvo.com>
AuthorDate: Fri Apr 16 00:54:22 2021 +0300
Code review.
---
.../scala/org/apache/nlpcraft/probe/mgrs/NCProbeSynonym.scala | 4 +---
.../org/apache/nlpcraft/probe/mgrs/model/NCModelManager.scala | 8 ++++----
.../nlpcraft/probe/mgrs/nlp/enrichers/model/NCModelEnricher.scala | 1 -
3 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/NCProbeSynonym.scala b/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/NCProbeSynonym.scala
index d5361f8..d3d1e5a 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/NCProbeSynonym.scala
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/NCProbeSynonym.scala
@@ -198,9 +198,7 @@ class NCProbeSynonym(
else
false
}
-
-
-
+
/**
*
* @param toks
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/model/NCModelManager.scala b/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/model/NCModelManager.scala
index 5c4ca4c..e2e0833 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/model/NCModelManager.scala
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/model/NCModelManager.scala
@@ -73,10 +73,10 @@ object NCModelManager extends NCService with DecorateAsScala {
s"Origin: ${mdl.getOrigin}",
s"Elements: ${withWarn(w.elements.keySet.size)}",
s"Synonyms:",
- s" - Simple, continuous: $contCnt",
- s" - Simple, sparse: $sparseCnt",
- s" - IDL, continuous: $contIdlCnt",
- s" - IDL, sparse: $sparseIdlCnt",
+ s" Simple continuous: $contCnt",
+ s" Simple sparse: $sparseCnt",
+ s" IDL continuous: $contIdlCnt",
+ s" IDL sparse: $sparseIdlCnt",
s"Intents: ${withWarn(w.intents.size)}"
)
})
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/enrichers/model/NCModelEnricher.scala b/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/enrichers/model/NCModelEnricher.scala
index 52a84f0..1bea582 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/enrichers/model/NCModelEnricher.scala
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/enrichers/model/NCModelEnricher.scala
@@ -406,7 +406,6 @@ object NCModelEnricher extends NCProbeEnricher with DecorateAsScala {
h.complexes.par.
flatMap(complexSeq ⇒ {
- //val rec = complexSeq.tokensComplexes.filter(_.isSubsetOf(idxMin, idxMax, idxs))
val rec = complexSeq.tokensComplexes.filter(_.wordIndexes.exists(idxs.contains))
// Drops without tokens (IDL part works with tokens).