You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wsrp4j-dev@portals.apache.org by Diego Louzán <dl...@apache.org> on 2005/08/30 05:46:50 UTC
¿Bug in pluto?
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
When integrating pluto-1.0.1-rc4 with wsrp4j I found what I think is a pluto
bug. In ConfigService.properties, with rc4 there's a new property:
...
portletcontainer.supportsBuffering=no
...
This property is used in org.apache.pluto.PortletContainerImpl:
...
private static String CONTAINER_SUPPORTS_BUFFERING =
"portletcontainer.supportsBuffering";
...
public void init(...) {
...
Boolean b = (Boolean)properties.get(CONTAINER_SUPPORTS_BUFFERING);
...
}
But in org.apache.pluto.portalImpl.Servlet it's not used at all, it's ignored:
...
Properties properties = new Properties();
try
{
PortletContainerFactory.
getPortletContainer().
init(uniqueContainerName, config, environment, properties);
}
...
So? I've had some problems with this integrating pluto & wsrp4j because the
current version of wsrp4j passed null in properties field.
Carsten or Elliot, if you think this is a pluto bug, please forward it to
pluto-dev. Thank you.
Regards.
Diego.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFDE9aqgyzZYflJelERAmfKAJ9hmaJiRXG/pU1U+WABgrYezCB4jQCeIDC4
WyoVGvGtsKeT5wWkap3Osd8=
=F3uI
-----END PGP SIGNATURE-----
Re: ¿Bug in pluto?
Posted by Diego Louzán <dl...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The one who is asleep it's me lol (it's been a lot of work last days). I was
checking rc3 code instead of rc4. Sorry for the incovenience. I'm resolving it
right now. Thank you :-)
Regards.
Diego.
Elliot Metsger wrote:
> Hi Diego,
>
> This looks to be related to PLUTO-112. But I have a question, are you
> looking at the source code for 1.0.1 rc4?
>
> I pulled a fresh copy of 1.0.1rc4 from ASF SVN and this is what I see in
> portal/src/java/org/apache/pluto/portalImpl/Servlet.java:
> ...
> Properties containerProperties = new Properties();
>
> containerProperties.put(CONTAINER_SUPPORTS_BUFFERING, new
> Boolean(allowSetBufferSize));
>
> // Properties properties = new Properties();
>
> try
> {
> PortletContainerFactory.
> getPortletContainer().
> // init(uniqueContainerName, config, environment,
> properties);
> init(uniqueContainerName, config, environment,
> containerProperties);
> }
> catch
> ...
>
>
> But perhaps I'm missing something as its late :( I also see it in the
> downloadable source distribution for rc4.
>
> Best regards,
> Elliot
>
>
>
> Diego Louzán wrote:
>
> When integrating pluto-1.0.1-rc4 with wsrp4j I found what I think is a
> pluto
> bug. In ConfigService.properties, with rc4 there's a new property:
>
> ...
> portletcontainer.supportsBuffering=no
> ...
>
> This property is used in org.apache.pluto.PortletContainerImpl:
>
> ...
> private static String CONTAINER_SUPPORTS_BUFFERING =
> "portletcontainer.supportsBuffering";
> ...
> public void init(...) {
> ...
> Boolean b = (Boolean)properties.get(CONTAINER_SUPPORTS_BUFFERING);
> ...
> }
>
> But in org.apache.pluto.portalImpl.Servlet it's not used at all, it's
> ignored:
>
> ...
> Properties properties = new Properties();
>
> try
> {
> PortletContainerFactory.
> getPortletContainer().
> init(uniqueContainerName, config, environment, properties);
> }
> ...
>
> So? I've had some problems with this integrating pluto & wsrp4j
> because the
> current version of wsrp4j passed null in properties field.
>
> Carsten or Elliot, if you think this is a pluto bug, please forward it to
> pluto-dev. Thank you.
>
> Regards.
> Diego.
>>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFDFJQngyzZYflJelERAlF0AJ9ju5/3gahVI0f2pBkdcE6PYmNDSwCgllqA
bqWu/wZZ8uQ1anQRagcyjGo=
=6+fK
-----END PGP SIGNATURE-----
Re: ¿Bug in pluto?
Posted by Elliot Metsger <em...@jhu.edu>.
Hi Diego,
This looks to be related to PLUTO-112. But I have a question, are you
looking at the source code for 1.0.1 rc4?
I pulled a fresh copy of 1.0.1rc4 from ASF SVN and this is what I see in
portal/src/java/org/apache/pluto/portalImpl/Servlet.java:
...
Properties containerProperties = new Properties();
containerProperties.put(CONTAINER_SUPPORTS_BUFFERING, new
Boolean(allowSetBufferSize));
// Properties properties = new Properties();
try
{
PortletContainerFactory.
getPortletContainer().
// init(uniqueContainerName, config, environment,
properties);
init(uniqueContainerName, config, environment,
containerProperties);
}
catch
...
But perhaps I'm missing something as its late :( I also see it in the
downloadable source distribution for rc4.
Best regards,
Elliot
Diego Louzán wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> When integrating pluto-1.0.1-rc4 with wsrp4j I found what I think is a pluto
> bug. In ConfigService.properties, with rc4 there's a new property:
>
> ...
> portletcontainer.supportsBuffering=no
> ...
>
> This property is used in org.apache.pluto.PortletContainerImpl:
>
> ...
> private static String CONTAINER_SUPPORTS_BUFFERING =
> "portletcontainer.supportsBuffering";
> ...
> public void init(...) {
> ...
> Boolean b = (Boolean)properties.get(CONTAINER_SUPPORTS_BUFFERING);
> ...
> }
>
> But in org.apache.pluto.portalImpl.Servlet it's not used at all, it's ignored:
>
> ...
> Properties properties = new Properties();
>
> try
> {
> PortletContainerFactory.
> getPortletContainer().
> init(uniqueContainerName, config, environment, properties);
> }
> ...
>
> So? I've had some problems with this integrating pluto & wsrp4j because the
> current version of wsrp4j passed null in properties field.
>
> Carsten or Elliot, if you think this is a pluto bug, please forward it to
> pluto-dev. Thank you.
>
> Regards.
> Diego.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.6 (GNU/Linux)
>
> iD8DBQFDE9aqgyzZYflJelERAmfKAJ9hmaJiRXG/pU1U+WABgrYezCB4jQCeIDC4
> WyoVGvGtsKeT5wWkap3Osd8=
> =F3uI
> -----END PGP SIGNATURE-----
>