You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2015/07/07 11:59:33 UTC

resource leaks exception to the 2LGTM rule

Guys `n' Dolls,

I want an exception to the rule requiring two LGTMs for any commit:
coverity reports 73 high impact issues at the moment. All of them are
resource leaks that can be solved by the well known pattern of using
try-with-resource. We (and I do mean a lot of us) have been fixing
this in this particular way.

I want permission to go ahead and address these issues and not create
one huge or 73 small PRs. Can I?

thanks,
-- 
Daan

Re: resource leaks exception to the 2LGTM rule

Posted by Daan Hoogland <da...@gmail.com>.

Sorre Sebastien, I will -1 squashing any other then typo or to and fro commits.

On Tue, Jul 7, 2015 at 12:15 PM, sebgoa <ru...@gmail.com> wrote:
>
> On Jul 7, 2015, at 12:10 PM, Daan Hoogland <da...@gmail.com> wrote:
>
>> I will not do it in one commit, if we insist on a PR i will do 73 commits
>> in one PR.
>>
>
> are you automating those commits ?
>
> I would not mind scanning through them and giving green light. and in that case squash might be good :)
>
>> On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav <ro...@shapeblue.com>
>> wrote:
>>
>>>
>>> On 07-Jul-2015, at 3:29 pm, Daan Hoogland <da...@gmail.com> wrote:
>>>
>>> I want permission to go ahead and address these issues and not create
>>> one huge or 73 small PRs. Can I?
>>>
>>>
>>> One huge commit would be fine, testing/merging 73 small PRs is going to
>>> be some work.
>>>
>>> Regards,
>>> Rohit Yadav
>>> Software Architect, ShapeBlue
>>>
>>>
>>>
>>>
>>> M. +91 88 262 30892 | rohit.yadav@shapeblue.com
>>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>>
>>>
>>>
>>>
>>> Find out more about ShapeBlue and our range of CloudStack related services
>>>
>>> IaaS Cloud Design & Build
>>> <http://shapeblue.com/iaas-cloud-design-and-build//>
>>> CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/>
>>> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/>
>>> CloudStack Software Engineering
>>> <http://shapeblue.com/cloudstack-software-engineering/>
>>> CloudStack Infrastructure Support
>>> <http://shapeblue.com/cloudstack-infrastructure-support/>
>>> CloudStack Bootcamp Training Courses
>>> <http://shapeblue.com/cloudstack-training/>
>>>
>>> This email and any attachments to it may be confidential and are intended
>>> solely for the use of the individual to whom it is addressed. Any views or
>>> opinions expressed are solely those of the author and do not necessarily
>>> represent those of Shape Blue Ltd or related companies. If you are not the
>>> intended recipient of this email, you must neither take any action based
>>> upon its contents, nor copy or show it to anyone. Please contact the sender
>>> if you believe you have received this email in error. Shape Blue Ltd is a
>>> company incorporated in England & Wales. ShapeBlue Services India LLP is a
>>> company incorporated in India and is operated under license from Shape Blue
>>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
>>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
>>> a company registered by The Republic of South Africa and is traded under
>>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>>>
>>
>>
>>
>> --
>> Daan
>



-- 
Daan

Re: resource leaks exception to the 2LGTM rule

Posted by sebgoa <ru...@gmail.com>.

On Jul 7, 2015, at 12:10 PM, Daan Hoogland <da...@gmail.com> wrote:

> I will not do it in one commit, if we insist on a PR i will do 73 commits
> in one PR.
> 

are you automating those commits ?

I would not mind scanning through them and giving green light. and in that case squash might be good :)

> On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav <ro...@shapeblue.com>
> wrote:
> 
>> 
>> On 07-Jul-2015, at 3:29 pm, Daan Hoogland <da...@gmail.com> wrote:
>> 
>> I want permission to go ahead and address these issues and not create
>> one huge or 73 small PRs. Can I?
>> 
>> 
>> One huge commit would be fine, testing/merging 73 small PRs is going to
>> be some work.
>> 
>> Regards,
>> Rohit Yadav
>> Software Architect, ShapeBlue
>> 
>> 
>> 
>> 
>> M. +91 88 262 30892 | rohit.yadav@shapeblue.com
>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>> 
>> 
>> 
>> 
>> Find out more about ShapeBlue and our range of CloudStack related services
>> 
>> IaaS Cloud Design & Build
>> <http://shapeblue.com/iaas-cloud-design-and-build//>
>> CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/>
>> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/>
>> CloudStack Software Engineering
>> <http://shapeblue.com/cloudstack-software-engineering/>
>> CloudStack Infrastructure Support
>> <http://shapeblue.com/cloudstack-infrastructure-support/>
>> CloudStack Bootcamp Training Courses
>> <http://shapeblue.com/cloudstack-training/>
>> 
>> This email and any attachments to it may be confidential and are intended
>> solely for the use of the individual to whom it is addressed. Any views or
>> opinions expressed are solely those of the author and do not necessarily
>> represent those of Shape Blue Ltd or related companies. If you are not the
>> intended recipient of this email, you must neither take any action based
>> upon its contents, nor copy or show it to anyone. Please contact the sender
>> if you believe you have received this email in error. Shape Blue Ltd is a
>> company incorporated in England & Wales. ShapeBlue Services India LLP is a
>> company incorporated in India and is operated under license from Shape Blue
>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
>> a company registered by The Republic of South Africa and is traded under
>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>> 
> 
> 
> 
> -- 
> Daan

Re: resource leaks exception to the 2LGTM rule

Posted by Daan Hoogland <da...@gmail.com>.

On Tue, Jul 7, 2015 at 1:37 PM, Rajani Karuturi <ra...@apache.org> wrote:
> This not a good candidate for squashing/huge commit.
> If a regression is found in any of the fixes, it will be easier to just
> revert it than reverting all the 70 commits.
>
> ~Rajani


Thanks Rajani, I allready made a booboo in the first (it wouldn't have
slipped through in this case though:)

-- 
Daan

Re: resource leaks exception to the 2LGTM rule

Posted by Rajani Karuturi <ra...@apache.org>.

This not a good candidate for squashing/huge commit.
If a regression is found in any of the fixes, it will be easier to just
revert it than reverting all the 70 commits.

~Rajani

On Tue, Jul 7, 2015 at 3:47 PM, Rohit Yadav <ro...@shapeblue.com>
wrote:

>
> On 07-Jul-2015, at 3:40 pm, Daan Hoogland <da...@gmail.com> wrote:
>
> I will not do it in one commit, if we insist on a PR i will do 73 commits
> in one PR.
>
>
>  Fine.
>
>  Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
>
>
> M. +91 88 262 30892 | rohit.yadav@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> <http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/>
> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/>
> CloudStack Software Engineering
> <http://shapeblue.com/cloudstack-software-engineering/>
> CloudStack Infrastructure Support
> <http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses
> <http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>

Re: resource leaks exception to the 2LGTM rule

Posted by Rohit Yadav <ro...@shapeblue.com>.

On 07-Jul-2015, at 3:40 pm, Daan Hoogland <da...@gmail.com>> wrote:

I will not do it in one commit, if we insist on a PR i will do 73 commits
in one PR.

Fine.

Regards,
Rohit Yadav
Software Architect, ShapeBlue

[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]

M. +91 88 262 30892 | rohit.yadav@shapeblue.com<ma...@shapeblue.com>
Blog: bhaisaab.org<http://bhaisaab.org> | Twitter: @_bhaisaab

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge - rapid IaaS deployment framework<http://shapeblue.com/csforge/>
CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/>

This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: resource leaks exception to the 2LGTM rule

Posted by Daan Hoogland <da...@gmail.com>.

I will not do it in one commit, if we insist on a PR i will do 73 commits
in one PR.

On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav <ro...@shapeblue.com>
wrote:

>
> On 07-Jul-2015, at 3:29 pm, Daan Hoogland <da...@gmail.com> wrote:
>
> I want permission to go ahead and address these issues and not create
> one huge or 73 small PRs. Can I?
>
>
>  One huge commit would be fine, testing/merging 73 small PRs is going to
> be some work.
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
>
>
> M. +91 88 262 30892 | rohit.yadav@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> <http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/>
> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/>
> CloudStack Software Engineering
> <http://shapeblue.com/cloudstack-software-engineering/>
> CloudStack Infrastructure Support
> <http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses
> <http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>



-- 
Daan

Re: resource leaks exception to the 2LGTM rule

Posted by Rohit Yadav <ro...@shapeblue.com>.

On 07-Jul-2015, at 3:29 pm, Daan Hoogland <da...@gmail.com>> wrote:

I want permission to go ahead and address these issues and not create
one huge or 73 small PRs. Can I?

One huge commit would be fine, testing/merging 73 small PRs is going to be some work.

Regards,
Rohit Yadav
Software Architect, ShapeBlue

[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]

M. +91 88 262 30892 | rohit.yadav@shapeblue.com<ma...@shapeblue.com>
Blog: bhaisaab.org<http://bhaisaab.org> | Twitter: @_bhaisaab

Find out more about ShapeBlue and our range of CloudStack related services