[jira] [Commented] (OAK-2454) Upgrade: reduce implementation dependency

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298789#comment-14298789 ] 

angela commented on OAK-2454:
-----------------------------

committed the updated patch with another fix ({{UpgradeRoot.getContentSession}} must not throw) at revision 1656042.
i don't particularly like {{UpgradeRoot}} as it doesn't properly implement the contract defined by the {{Root}} but ended up
preferring this over having multiple calls to {{Root.commit}} during the upgrade process.

i will keep a closer eye on the upgrade tests to see if this modification causes some untested failures.

> Upgrade: reduce implementation dependency
> -----------------------------------------
>
>                 Key: OAK-2454
>                 URL: https://issues.apache.org/jira/browse/OAK-2454
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: upgrade
>            Reporter: angela
>             Fix For: 1.1.6
>
>         Attachments: OAK-2454-2.patch, OAK-2454.patch
>
>
> the current upgrade code heavily relies on implementation details. i would prefer to use existing functionality like privilege-mgt and node type management instead of copying that code to the upgrade.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)