You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/10/18 22:13:02 UTC

[PR] [FLINK-33309] Add `-Djava.security.manager=allow` [flink]

snuyanzin opened a new pull request, #23547:
URL: https://github.com/apache/flink/pull/23547

   
   ## What is the purpose of the change
   Since because of JEP411 [1] starting from java 18 default value of `java.security.manager` will be disallow the PR adds allow optio where it is needed
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no)
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33309] Add `-Djava.security.manager=allow` [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.

flinkbot commented on PR #23547:
URL: https://github.com/apache/flink/pull/23547#issuecomment-1769481551

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8dc5eda4eefe7102af4b4c546795ee24ec3ddea1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8dc5eda4eefe7102af4b4c546795ee24ec3ddea1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8dc5eda4eefe7102af4b4c546795ee24ec3ddea1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33309] Add `-Djava.security.manager=allow` [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.

zentol commented on code in PR #23547:
URL: https://github.com/apache/flink/pull/23547#discussion_r1380568055


##########
flink-dist/src/main/flink-bin/bin/config.sh:
##########
@@ -334,6 +334,12 @@ if [ -z "${FLINK_ENV_JAVA_OPTS}" ]; then
 
     # Remove leading and ending double quotes (if present) of value
     FLINK_ENV_JAVA_OPTS="-XX:+IgnoreUnrecognizedVMOptions $( echo "${FLINK_ENV_JAVA_OPTS}" | sed -e 's/^"//'  -e 's/"$//' )"
+
+    JAVA_SPEC_VERSION=`"${JAVA_RUN}" -XshowSettings:properties 2>&1 | grep "java.specification.version" | cut -d "=" -f 2 |  tr -d '[:space:]'`
+    if [[ $(echo "$JAVA_SPEC_VERSION > 17" | bc )  == "1"  ]]; then

Review Comment:
   bc isn't available in our CI image. any reason this cant use plain bash arithmetic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org